Suriyakumarvijayanayagam
c7312d31b4
Audited before its first run, because deploy.sh taught us what a script nobody has executed contains. PowerShell's $ErrorActionPreference = "Stop" governs PowerShell errors. A native .exe returning non-zero is not one, so `npm ci` and `npm run build` were unchecked and the script sailed past them. That matters here more than anywhere else: a built frontend/dist is COMMITTED to this repository so `go build` type-checks without npm, which means a silently failed npm build leaves the old one in place and it embeds perfectly. The output is an installer that builds, installs, opens and shows a stale UI, with nothing anywhere saying so - the silent-wrong outcome, reached through the single most likely failure on a fresh Windows box. A Run() helper now throws on any non-zero native exit, across nine call sites: venv, both pip installs, pytest, pyinstaller, npm ci, npm build, both go builds, and the frozen engine's own smoke test. The pip installs were also piped to Out-Null, so a failure there produced no output AND no stop. run-local.sh has already been caught making exactly that mistake, where it "exited at step 5 with no output at all - the single hardest failure to diagnose, and it took three runs to find". Not worth repeating in a script that runs on a machine nobody is sitting at. Two smaller ones from the same read: - frontend\dist\index.html is deleted before npm runs, and its absence afterwards is an error. Checking the exit code is not enough when the artefact it was meant to produce is already sitting there from git. - `go build -o dist\...` does not create its target directory, and dist\ is gitignored. It exists on a fresh clone only because PyInstaller ran first and made it - an ordering dependency nothing stated. Stated now, and created explicitly. None of this has been run on Windows. It cannot be from here - PyInstaller freezes the interpreter and native wheels of the machine it runs on. What this buys is that the first Windows run fails for a real reason rather than for a bug in the script. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KGcjxF1cNLcuwc3DAPcnfj
7.1 KiB
7.1 KiB