3bd2dfc002
This commit removes legacy App Engine deployment artifacts and updates the Makefile to reflect the successful migration of the `internal-launchpad` service to Cloud Run. The following changes were made: - Deleted obsolete permission scripts: - `fix-appengine-permissions-complete.sh` - `fix-project-level-permissions.sh` - `create-missing-repository.sh` - Removed the `firebase/internal-launchpad/app.yaml` file. - Updated `firebase.json` to remove the `launchpad` hosting configuration. These changes streamline the repository, reduce developer confusion, and prevent the accidental use of outdated deployment logic.
36 lines
2.1 KiB
Markdown
36 lines
2.1 KiB
Markdown
# Refactor: Clean up legacy App Engine deployment artifacts
|
|
Labels: refactor, infra
|
|
Milestone: Phase 1: Foundation & Dev Environment Setup
|
|
|
|
## Context
|
|
Now that the `internal-launchpad` service has been successfully migrated from App Engine to Cloud Run, a number of scripts, configurations, and files related to the old App Engine deployment method are obsolete.
|
|
|
|
This technical debt should be removed to clean up the repository, reduce confusion for developers, and prevent the accidental use of outdated deployment logic.
|
|
|
|
## Action Items
|
|
|
|
1. **Delete Obsolete Permission Scripts:**
|
|
The following shell scripts were created to fix permission issues specific to the App Engine deployment and are no longer needed. They should be deleted:
|
|
- `fix-appengine-permissions-complete.sh`
|
|
- `fix-project-level-permissions.sh`
|
|
- `create-missing-repository.sh`
|
|
|
|
2. **Remove App Engine Configuration:**
|
|
The `app.yaml` file within the `firebase/internal-launchpad/` directory was specific to the App Engine runtime and is now ignored. It should be deleted.
|
|
|
|
3. **Update Firebase Hosting Configuration:**
|
|
The `firebase.json` file still contains a hosting target named `launchpad` that points to the `firebase/internal-launchpad` directory. This configuration is no longer used since the launchpad is served by Cloud Run.
|
|
- Remove the `launchpad` target object from the `hosting` array in `firebase.json`.
|
|
|
|
## Acceptance Criteria
|
|
- The three shell scripts listed above are deleted from the repository.
|
|
- The `firebase/internal-launchpad/app.yaml` file is deleted.
|
|
- The `firebase.json` file no longer contains the `launchpad` hosting configuration.
|
|
- The `make deploy-launchpad-full` command remains the sole method for deploying the launchpad.
|
|
|
|
---
|
|
## SR&ED Justification
|
|
|
|
**Eligibility:** Not Eligible.
|
|
|
|
**Reasoning:** This task involves code and configuration cleanup, which is considered standard software engineering practice and maintenance. It does not involve systematic investigation to resolve a technological uncertainty, nor does it lead to a technological advancement. The outcome is an improved and cleaner codebase, not new technological knowledge. |