Files
nearle_pos/test/unit/checkout_test.dart
Suriya af3933092f Fix billing data integrity, sale atomicity and stock safety
Bills were persisted correctly but read back wrong. The read path rebuilt a
cart from its lines alone, dropping bill-level discounts and loyalty, so every
figure derived from a stored bill was overstated: the upload payload, the day
archive and the shift report. A discounted 529 bill read back as 620.

Money and data integrity
- order_dao: restore bill_discount and points_redeemed when rebuilding a cart;
  keep the reconstruction tier-less so the membership discount is not applied
  twice. Trust the recorded total and points via SaleTransaction.storedTotal.
- checkout_sale + order_dao.commitSale: write the bill, its stock movement and
  the loyalty update in one transaction. Previously a failure part-way through
  left a persisted bill the cashier believed had failed, inviting a duplicate.
- checkout_sale: re-check every line against live stock. A parked bill resumed
  after its stock was sold passed validation and oversold.
- catalogue_dao: allocate the invoice sequence in one transaction; the previous
  read-modify-write could hand two sales the same number and fail UNIQUE.
- local_store: replay unsynced sales after a catalogue import, so a mid-shift
  re-import cannot restore stock that has already been sold.
- payment_controller: stamp the signed-in operator on the bill instead of the
  hardcoded seed session, and pass the terminal id through.
- cart: reconcile per-slab GST against the bill total so the parts sum to the
  whole on a tax invoice.

Sync and reporting
- sync_repository: drain unsynced bills in a loop rather than silently capping
  at one page; stop on rejection so rejected rows cannot loop forever.
- sync_log_dao (new): persist the sync history to the sync_log table, which the
  schema already defined but nothing used. It was in memory, so the only record
  that bills had been uploaded died at restart.
- Scope shift reports by cashier. day_archive is re-keyed to
  (business_date, cashier_name) so a till stays settleable after its bills are
  uploaded and deleted. Schema v4 with a migration that carries v3 rows across.

Input and UI
- barcode_service: consume machine-paced keystrokes so a scan cannot also land
  in the focused field, and raise the bar to 60ms/char while a text field has
  focus so typing a mobile number is not read as a scan. Clock and focus check
  injected so the behaviour is testable.
- primary_button: make the label flexible; label plus trailing total overflowed
  the Charge button by up to 131px.
- app_router: redirect instead of null-casting when the receipt route is
  entered without its transaction.
- customer_repository: reduce the search query to digits so a punctuated mobile
  number matches.

Cleanup
- Remove TransactionRepository.save, CustomerRepository.recordSale and
  OrderDao.insertOrder, all superseded by commitSale.
- dart fix across the tree; 251 analyzer issues down to 3 info-level.

Tests: 23 passing / 15 failing -> 90 passing. Fixed the two defects that broke
the existing suite (containsAll type argument, reset() needing a catalogue) and
deleted the leftover template test. Added coverage for the order round trip,
the day archive after a real sync, stock safety, checkout atomicity, the v3->v4
migration, scanner-versus-human input, and an app-level smoke test that renders
every module.

Note: bills already uploaded with a discount went up overstated. This stops it
happening again but does not correct historical server data.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-07-31 18:34:10 +05:30

265 lines
8.2 KiB
Dart

import 'package:flutter_test/flutter_test.dart';
import 'package:nearle_pos/data/datasources/local_store.dart';
import 'package:nearle_pos/data/datasources/seed_data.dart';
import 'package:nearle_pos/data/repositories/customer_repository_impl.dart';
import 'package:nearle_pos/data/repositories/product_repository_impl.dart';
import 'package:nearle_pos/data/repositories/transaction_repository_impl.dart';
import 'package:nearle_pos/domain/entities/cart.dart';
import 'package:nearle_pos/domain/entities/customer.dart';
import 'package:nearle_pos/domain/entities/transaction.dart';
import 'package:nearle_pos/domain/usecases/checkout_sale.dart';
void main() {
late LocalStore store;
late ProductRepositoryImpl products;
late CustomerRepositoryImpl customers;
late TransactionRepositoryImpl transactions;
late CheckoutSale checkout;
setUpAll(() {
// The store only reaches for demo rows through these hooks, so the seed has
// to be registered before any test asks for a catalogue.
LocalStore.registerSeed(
products: SeedData.products,
customers: SeedData.customers,
);
});
setUp(() async {
store = LocalStore.instance;
// Fresh seed for every test so stock and invoice sequence never leak.
await store.reset(withCatalogue: true);
products = ProductRepositoryImpl(store);
customers = CustomerRepositoryImpl(store);
transactions = TransactionRepositoryImpl(store);
checkout = CheckoutSale(
productRepository: products,
customerRepository: customers,
transactionRepository: transactions,
);
});
/// Amul Milk 1L: 62.00, 5% GST, 50 in stock.
Future<Cart> milkCart({int qty = 2, String? customerId}) async {
final milk = (await products.findByBarcode('8901234500011'))!;
final customer =
customerId == null ? null : await customers.findById(customerId);
return Cart(
lines: [CartLine(product: milk, quantity: qty.toDouble())],
customer: customer,
);
}
group('successful checkout', () {
test('records the sale and returns an invoice', () async {
final cart = await milkCart();
expect(cart.grandTotal, 124);
final result = await checkout(
cart: cart,
payments: const [
PaymentSplit(method: PaymentMethod.cash, amount: 124, tendered: 200),
],
cashierName: 'Suriya',
);
final txn = result.transaction;
expect(txn.total, 124);
expect(txn.amountPaid, 124);
expect(txn.changeDue, 76);
expect(txn.isFullySettled, isTrue);
expect(txn.isSplit, isFalse);
expect(txn.invoiceNumber, contains('00001'));
expect(txn.status, TransactionStatus.completed);
});
test('decrements stock by the quantity sold', () async {
final cart = await milkCart();
await checkout(
cart: cart,
payments: const [
PaymentSplit(method: PaymentMethod.cash, amount: 124, tendered: 124),
],
cashierName: 'Suriya',
);
final milk = await products.findByBarcode('8901234500011');
expect(milk!.stock, 48);
});
test('persists the transaction to history', () async {
final cart = await milkCart();
await checkout(
cart: cart,
payments: const [
PaymentSplit(method: PaymentMethod.cash, amount: 124, tendered: 124),
],
cashierName: 'Suriya',
);
final history = await transactions.history();
expect(history, hasLength(1));
expect(await transactions.salesTotalForDay(DateTime.now()), 124);
});
test('accepts a split across two tenders', () async {
final cart = await milkCart();
final result = await checkout(
cart: cart,
payments: const [
PaymentSplit(method: PaymentMethod.cash, amount: 100, tendered: 100),
PaymentSplit(
method: PaymentMethod.upi,
amount: 24,
reference: 'UPI-991',
),
],
cashierName: 'Suriya',
);
expect(result.transaction.isSplit, isTrue);
expect(result.transaction.amountPaid, 124);
expect(result.transaction.paymentSummary, 'Cash + UPI');
});
test('moves loyalty points and lifetime spend for a member', () async {
final cart = await milkCart(customerId: 'c001');
// 124 less the 2% silver discount, rounded.
expect(cart.membershipDiscountAmount, 2.48);
expect(cart.grandTotal, 122);
expect(cart.pointsEarned, 12);
final result = await checkout(
cart: cart,
payments: const [
PaymentSplit(method: PaymentMethod.cash, amount: 122, tendered: 200),
],
cashierName: 'Suriya',
);
final updated = result.updatedCustomer!;
expect(updated.loyaltyPoints, 332); // 320 + 12
expect(updated.lifetimeSpend, 24622); // 24500 + 122
expect(updated.visitCount, 42);
});
});
group('rejected checkout', () {
test('refuses an empty cart', () async {
expect(
() => checkout(
cart: Cart.empty,
payments: const [
PaymentSplit(method: PaymentMethod.cash, amount: 0),
],
cashierName: 'Suriya',
),
throwsA(isA<CheckoutFailure>()),
);
});
test('refuses a bill with no tender', () async {
final cart = await milkCart();
expect(
() => checkout(cart: cart, payments: const [], cashierName: 'Suriya'),
throwsA(isA<CheckoutFailure>()),
);
});
test('refuses an underpayment', () async {
final cart = await milkCart();
expect(
() => checkout(
cart: cart,
payments: const [
PaymentSplit(method: PaymentMethod.cash, amount: 100, tendered: 100),
],
cashierName: 'Suriya',
),
throwsA(isA<CheckoutFailure>()),
);
});
test('refuses to sell more than is in stock', () async {
final cart = await milkCart(qty: 999);
expect(
() => checkout(
cart: cart,
payments: [
PaymentSplit(
method: PaymentMethod.cash,
amount: cart.grandTotal,
tendered: cart.grandTotal,
),
],
cashierName: 'Suriya',
),
throwsA(isA<CheckoutFailure>()),
);
});
test('leaves stock untouched when validation fails', () async {
final cart = await milkCart();
try {
await checkout(cart: cart, payments: const [], cashierName: 'Suriya');
} on CheckoutFailure {
// expected
}
final milk = await products.findByBarcode('8901234500011');
expect(milk!.stock, 50);
});
});
group('repositories', () {
test('finds a customer by mobile number', () async {
final found = await customers.findByMobile('9876543210');
expect(found?.name, 'Abhishek');
expect(await customers.findByMobile('0000000000'), isNull);
});
test('rejects a duplicate mobile number on create', () async {
// 9876543210 already belongs to the seeded customer c001.
expect(
() => customers.create(
const Customer(id: '', name: 'Impostor', mobile: '9876543210'),
),
throwsA(isA<StateError>()),
);
});
test('creates a customer with a generated id and zeroed loyalty', () async {
final created = await customers.create(
const Customer(id: '', name: 'New Shopper', mobile: '9000011111'),
);
expect(created.id, isNotEmpty);
expect(created.loyaltyPoints, 0);
expect(created.lifetimeSpend, 0);
expect(created.tier, MembershipTier.bronze);
expect(await customers.findByMobile('9000011111'), isNotNull);
});
test('ranks an exact barcode above a fuzzy name match', () async {
final results = await products.search('8901234500011');
expect(results.first.name, 'Amul Milk 1L');
});
test('parks and resumes a bill', () async {
final cart = await milkCart();
await transactions.park(
ParkedBill(id: 'park-1', cart: cart, parkedAt: DateTime.now()),
);
expect(await transactions.parkedBills(), hasLength(1));
await transactions.removeParked('park-1');
expect(await transactions.parkedBills(), isEmpty);
});
});
}