Files
nearle_pos/test/unit/barcode_service_test.dart
Suriya af3933092f Fix billing data integrity, sale atomicity and stock safety
Bills were persisted correctly but read back wrong. The read path rebuilt a
cart from its lines alone, dropping bill-level discounts and loyalty, so every
figure derived from a stored bill was overstated: the upload payload, the day
archive and the shift report. A discounted 529 bill read back as 620.

Money and data integrity
- order_dao: restore bill_discount and points_redeemed when rebuilding a cart;
  keep the reconstruction tier-less so the membership discount is not applied
  twice. Trust the recorded total and points via SaleTransaction.storedTotal.
- checkout_sale + order_dao.commitSale: write the bill, its stock movement and
  the loyalty update in one transaction. Previously a failure part-way through
  left a persisted bill the cashier believed had failed, inviting a duplicate.
- checkout_sale: re-check every line against live stock. A parked bill resumed
  after its stock was sold passed validation and oversold.
- catalogue_dao: allocate the invoice sequence in one transaction; the previous
  read-modify-write could hand two sales the same number and fail UNIQUE.
- local_store: replay unsynced sales after a catalogue import, so a mid-shift
  re-import cannot restore stock that has already been sold.
- payment_controller: stamp the signed-in operator on the bill instead of the
  hardcoded seed session, and pass the terminal id through.
- cart: reconcile per-slab GST against the bill total so the parts sum to the
  whole on a tax invoice.

Sync and reporting
- sync_repository: drain unsynced bills in a loop rather than silently capping
  at one page; stop on rejection so rejected rows cannot loop forever.
- sync_log_dao (new): persist the sync history to the sync_log table, which the
  schema already defined but nothing used. It was in memory, so the only record
  that bills had been uploaded died at restart.
- Scope shift reports by cashier. day_archive is re-keyed to
  (business_date, cashier_name) so a till stays settleable after its bills are
  uploaded and deleted. Schema v4 with a migration that carries v3 rows across.

Input and UI
- barcode_service: consume machine-paced keystrokes so a scan cannot also land
  in the focused field, and raise the bar to 60ms/char while a text field has
  focus so typing a mobile number is not read as a scan. Clock and focus check
  injected so the behaviour is testable.
- primary_button: make the label flexible; label plus trailing total overflowed
  the Charge button by up to 131px.
- app_router: redirect instead of null-casting when the receipt route is
  entered without its transaction.
- customer_repository: reduce the search query to digits so a punctuated mobile
  number matches.

Cleanup
- Remove TransactionRepository.save, CustomerRepository.recordSale and
  OrderDao.insertOrder, all superseded by commitSale.
- dart fix across the tree; 251 analyzer issues down to 3 info-level.

Tests: 23 passing / 15 failing -> 90 passing. Fixed the two defects that broke
the existing suite (containsAll type argument, reset() needing a catalogue) and
deleted the leftover template test. Added coverage for the order round trip,
the day archive after a real sync, stock safety, checkout atomicity, the v3->v4
migration, scanner-versus-human input, and an app-level smoke test that renders
every module.

Note: bills already uploaded with a discount went up overstated. This stops it
happening again but does not correct historical server data.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-07-31 18:34:10 +05:30

170 lines
5.3 KiB
Dart

import 'package:flutter/services.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:nearle_pos/core/services/barcode_service.dart';
/// The scanner is a keyboard, so the only thing separating a scan from the
/// cashier typing is timing. These drive the handler with a controlled clock
/// rather than real delays, so the boundary is exact.
void main() {
late List<String> scans;
late int manualKeys;
late DateTime now;
late bool editingText;
setUp(() {
scans = [];
manualKeys = 0;
now = DateTime(2026, 7, 31, 10);
editingText = false;
});
BarcodeService build() => BarcodeService(
onScan: scans.add,
onManualKey: () => manualKeys++,
clock: () => now,
isEditingText: () => editingText,
);
KeyEvent char(String c) => KeyDownEvent(
physicalKey: PhysicalKeyboardKey.keyA,
logicalKey: LogicalKeyboardKey.keyA,
character: c,
timeStamp: Duration.zero,
);
KeyEvent enterKey() => const KeyDownEvent(
physicalKey: PhysicalKeyboardKey.enter,
logicalKey: LogicalKeyboardKey.enter,
timeStamp: Duration.zero,
);
/// Feeds [text] with a fixed gap between keystrokes, returning which
/// keystrokes the service swallowed.
List<bool> type(
BarcodeService service,
String text, {
required int gapMs,
}) {
return [
for (final c in text.split('')) ...[
() {
now = now.add(Duration(milliseconds: gapMs));
return service.handleKey(char(c));
}(),
],
];
}
group('scanner input', () {
test('a fast burst terminated by Enter is billed as a scan', () {
final service = build();
type(service, '8901234500011', gapMs: 5);
now = now.add(const Duration(milliseconds: 5));
final enterConsumed = service.handleKey(enterKey());
expect(scans, ['8901234500011']);
expect(enterConsumed, isTrue,
reason: 'the scanner terminator must not reach the focused field',);
expect(manualKeys, 0);
});
test('the burst is swallowed so it cannot also land in a text field', () {
final service = build();
final consumed = type(service, '8901234500011', gapMs: 5);
// The first keystroke cannot be judged yet — nothing has arrived to
// measure a gap against — so exactly one character escapes. Everything
// after it is recognised as machine-paced and consumed.
expect(consumed.first, isFalse);
expect(consumed.skip(1), everyElement(isTrue));
});
test('a scanner that sends no Enter still flushes on idle', () async {
final service = build();
type(service, '8901234500011', gapMs: 5);
expect(scans, isEmpty, reason: 'nothing has flushed yet');
await Future<void>.delayed(const Duration(milliseconds: 300));
expect(scans, ['8901234500011']);
});
});
group('human input', () {
test('typing at human speed is never treated as a scan', () {
final service = build();
final consumed = type(service, '9876543210', gapMs: 200);
now = now.add(const Duration(milliseconds: 200));
final enterConsumed = service.handleKey(enterKey());
expect(scans, isEmpty);
expect(consumed, everyElement(isFalse),
reason: 'hand-typed characters must reach the field',);
expect(enterConsumed, isFalse,
reason: 'swallowing Enter would break form submission',);
});
test('a fast typist in a text field does not trigger a phantom scan', () {
editingText = true;
final service = build();
// ~100ms per character is a quick typist and used to clear the bar.
type(service, '9876543210', gapMs: 100);
now = now.add(const Duration(milliseconds: 100));
final enterConsumed = service.handleKey(enterKey());
expect(scans, isEmpty,
reason: 'entering a mobile number must not jump to billing',);
expect(enterConsumed, isFalse);
});
test('the same speed does count as a scan when no field has focus', () {
editingText = false;
final service = build();
type(service, '9876543210', gapMs: 100);
now = now.add(const Duration(milliseconds: 100));
service.handleKey(enterKey());
expect(scans, ['9876543210']);
});
test('a pause mid-burst starts a new entry', () {
final service = build();
type(service, '890123', gapMs: 5);
now = now.add(const Duration(milliseconds: 500)); // cashier hesitates
type(service, '4500011', gapMs: 5);
now = now.add(const Duration(milliseconds: 5));
service.handleKey(enterKey());
expect(scans, ['4500011'],
reason: 'only the characters after the pause form the code',);
});
});
group('rejected input', () {
test('a buffer shorter than a barcode is reported as manual input', () {
final service = build();
type(service, 'abc', gapMs: 5);
now = now.add(const Duration(milliseconds: 5));
final enterConsumed = service.handleKey(enterKey());
expect(scans, isEmpty);
expect(manualKeys, 1);
expect(enterConsumed, isFalse);
});
test('non-alphanumeric characters are ignored entirely', () {
final service = build();
now = now.add(const Duration(milliseconds: 5));
expect(service.handleKey(char(r'$')), isFalse);
expect(scans, isEmpty);
});
});
}