Upload shopper registrations, and charge GST to the lines that earned it

Two defects that share a shape: a figure landing on the wrong record.

Bill-level discounts were apportioned across every line by a single
factor, so "20% off Beverages" pulled tax out of the atta line as well.
The bill total was right either way, which is what made it easy to ship
— only the slab split on a filed return was wrong. Targeted campaigns
now reduce the lines they name, and bill-wide reductions still spread
pro rata, so the arithmetic is unchanged wherever it was already right.

Shoppers registered at a till only ever reached the back office as three
fields riding along on a bill. Somebody who signed up and bought nothing
existed on one terminal and nowhere else, and two tills registering the
same mobile each minted their own row. Customers are now an outbox of
their own on pos/{store}/{terminal}/customer, and the id is a UUIDv5
over the normalised mobile number — so a hundred terminals agree on who
a shopper is without talking to each other.

Registrations go up before bills, and a failure there cannot strand a
day's takings. No loyalty figures are sent: they belong to the bill
stream, which is idempotent and knows about every counter.

Two things found while building it. Numbers were keyed on raw digits, so
a cashier typing +91 forked a shopper as effectively as a random id
would. And the sale path wrote the customer with ConflictAlgorithm
.replace, which is a DELETE and an INSERT — every column absent from the
row reverts to its schema default, so the new sync flag would have been
cleared by the shopper's next purchase.

Schema v8. Existing customers are queued rather than assumed sent: the
terminal cannot tell an imported row from a locally registered one, and
only one of those mistakes loses somebody.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Suriya
2026-08-03 11:34:27 +05:30
parent 467d5eee75
commit fe428931ec
24 changed files with 1274 additions and 78 deletions

View File

@@ -177,13 +177,113 @@ class Cart extends Equatable {
return v.clamp(0, double.infinity).toDouble().asMoney;
}
/// Proportion of the bill remaining after bill-level reductions. Used to
/// spread those reductions fairly across lines when apportioning GST.
double get _billFactor => subtotal <= 0 ? 1 : netAmount / subtotal;
/// Bill-level reductions, allocated to the lines that earned them.
///
/// Returns one figure per line, in [lines] order, summing to exactly
/// `subtotal - netAmount`.
///
/// This exists because GST is charged per line at that line's own slab, so
/// *which* line a discount lands on changes the tax. A bill-wide reduction —
/// a tier discount, a manual markdown, points redeemed — genuinely belongs to
/// every line, and spreading it pro rata is right. A campaign that names a
/// category or a product does not: taking "20% off Beverages" out of the
/// atta line as well understates the 18% slab and overstates the 5% one. The
/// bill total is identical either way, which is exactly why the error is easy
/// to ship — it only shows up in the slab split on a filed return.
List<double> get _lineReductions {
final result = List<double>.filled(lines.length, 0);
if (lines.isEmpty) return result;
// What the shopper actually saved at bill level, after the clamps in
// [billDiscountTotal] and [netAmount] have had their say.
final ceiling = (subtotal - netAmount).asMoney;
if (ceiling <= 0) return result;
void spread(double amount, bool Function(CartLine) targets) {
if (amount <= 0) return;
final matched = <int>[];
var base = 0.0;
for (var i = 0; i < lines.length; i++) {
if (!targets(lines[i])) continue;
matched.add(i);
base += lines[i].payable;
}
if (base <= 0) return;
for (final i in matched) {
result[i] += amount * (lines[i].payable / base);
}
}
for (final applied in appliedPromos) {
spread(applied.amount, (l) => applied.promo.targets(l.product));
}
spread(membershipDiscountAmount, (_) => true);
spread(manualBillDiscountAmount, (_) => true);
spread(loyaltyRedemptionValue, (_) => true);
return _fitToCeiling(result, ceiling);
}
/// Scales [raw] so it sums to [ceiling], with no line reduced below zero.
///
/// The components arrive individually clamped and then clamped again as a
/// group, so their raw sum is only approximately what came off the bill.
/// Scaling reconciles the two. Capping is a separate pass because a targeted
/// campaign can take a line to zero on its own, and the tier discount layered
/// on top would otherwise push it negative — which would show up as a
/// *credit* in that line's GST slab.
List<double> _fitToCeiling(List<double> raw, double ceiling) {
final out = List<double>.filled(raw.length, 0);
final open = [for (var i = 0; i < raw.length; i++) i];
var pool = ceiling;
// Loops because capping one line hands its excess back to the pool, which
// can in turn push another line past its own value.
while (open.isNotEmpty && pool > 0) {
final weight = open.fold(0.0, (sum, i) => sum + raw[i]);
if (weight <= 0) break;
final capped = open
.where((i) => pool * (raw[i] / weight) >= lines[i].payable)
.toList();
if (capped.isEmpty) {
for (final i in open) {
out[i] = pool * (raw[i] / weight);
}
break;
}
for (final i in capped) {
out[i] = lines[i].payable;
pool -= lines[i].payable;
open.remove(i);
}
}
return out;
}
/// What each line is worth after its share of the bill-level reductions.
List<double> get _lineNetAmounts {
final reductions = _lineReductions;
return [
for (var i = 0; i < lines.length; i++)
(lines[i].payable - reductions[i]).clamp(0, double.infinity).toDouble(),
];
}
/// GST payable across the bill, after apportioning bill-level discounts.
double get taxAmount =>
lines.fold(0.0, (sum, l) => sum + l.taxAmount * _billFactor).asMoney;
double get taxAmount {
final nets = _lineNetAmounts;
var total = 0.0;
for (var i = 0; i < lines.length; i++) {
total += nets[i] - nets[i] / (1 + lines[i].product.gstRate);
}
return total.asMoney;
}
double get cgst => (taxAmount / 2).asMoney;
double get sgst => (taxAmount / 2).asMoney;
@@ -198,10 +298,11 @@ class Cart extends Equatable {
/// side of the total printed on the same bill, which a tax invoice cannot
/// show; the residue is absorbed by the largest slab.
Map<double, double> get taxBreakdown {
final nets = _lineNetAmounts;
final raw = <double, double>{};
for (final line in lines) {
final rate = line.product.gstRate;
raw[rate] = (raw[rate] ?? 0) + line.taxAmount * _billFactor;
for (var i = 0; i < lines.length; i++) {
final rate = lines[i].product.gstRate;
raw[rate] = (raw[rate] ?? 0) + (nets[i] - nets[i] / (1 + rate));
}
if (raw.isEmpty) return const {};