ui/ux improvement

src/api/insights.ts

@@ -73,6 +73,41 @@ export const insightsApi = {
       pagesize: query.pagesize ?? 50,
     }),
 
+  /**
+   * Every order in a window, not the first page of them.
+   *
+   * Reports totals its figures from order ROWS — `getlocationsummary` carries no
+   * money and ignores the date picker, so the rows are the only source that both
+   * has revenue and respects the range. Reducing over a single `pagesize: 500`
+   * read made every one of those figures a silent lie the moment a tenant traded
+   * more than five hundred orders in the window: the page showed a total, gave no
+   * sign it was a partial one, and `api.list` discards the envelope so nothing
+   * downstream could even detect the cut.
+   *
+   * Paging stops on a SHORT PAGE rather than on a count the list endpoint does
+   * not return — the same rule `catalogue.idsByImageId` follows, and for the same
+   * reason: a total we would have to trust is worse than a page we can measure.
+   *
+   * `maxPages` is a real bound, not a formality. Something has to stop a loop
+   * pointed at production, and a window wide enough to exceed it is a window the
+   * reader should be told about rather than one we quietly keep fetching. Hence
+   * `truncated`, which the caller is expected to surface — the whole point of
+   * this function is that a partial total never again passes for a complete one.
+   */
+  ordersAll: async (
+    query: OrderQuery,
+    { pagesize = 500, maxPages = 10 }: { pagesize?: number; maxPages?: number } = {},
+  ): Promise<{ rows: OrderRow[]; truncated: boolean }> => {
+    const rows: OrderRow[] = [];
+    /* `pageno` is 1-based on this endpoint — the controller floors <= 0 to 1. */
+    for (let page = 1; page <= maxPages; page += 1) {
+      const batch = await insightsApi.orders({ ...query, pageno: page, pagesize });
+      rows.push(...batch);
+      if (batch.length < pagesize) return { rows, truncated: false };
+    }
+    return { rows, truncated: true };
+  },
+
   /**
    * The delivery jobs.
    *