require a mobile number when creating a till account
A till signs in with a mobile number and a PIN, but createposuser still
accepted an account without a number. Such an account cannot reach the
sign-in screen at all, and the failure surfaces at a counter in front of
a queue rather than at the point of creation. Enforced in CreatePosUser,
so both doors are covered: POST /pos/users from the terminal and
createposuser from the console share that path.
Two checks, not one. normalisePosPhone answers ("", nil) rather than an
error for a value holding no digits, so "abc" would have passed an
emptiness check, then been written as a blank and skipped the uniqueness
check below it — which is the hole this closes.
Scope is new accounts only. The column stays nullable and UpdatePosUser
still reads an empty contactno as "leave alone", so the accounts that
predate the number keep working through the backfill and cannot have
theirs cleared. The PIN stays optional at creation.
Also in this change:
- docs: correct both phone-login handovers, which claimed creation
already required a number. The sequencing note in the PIN handover
said step 2 was a backfill that could never be finished; it now is
one, and POS_LOGIN.md says which half of the pair creation enforces.
- docs: remove credentials from the examples. POS_PHONE_LOGIN_HANDOVER
carried a real-looking back-office pair and a generated till password,
and POS_LOGIN.md a second one.
- posController.Staff: the comment justified scoping by token because
"the answer carries PINs". It has not since the PIN left the wire. The
scoping is still right for a different reason, which the comment now
gives.
- scratch/posstaffsetup: takes both mobile numbers as arguments and
refuses to run without them. Generating stand-ins would have produced
exactly what this change prevents. Validated before the database is
opened, in plan mode too, so a dry run cannot print a plan that apply
would reject halfway through and leave half a shop set up.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -35,10 +35,10 @@ What changed is behaviour behind it.
|
||||
|
||||
```jsonc
|
||||
// Sign in by mobile — the new way
|
||||
{ "contactno": "9876543210", "password": "xHegDaH55ccWic" }
|
||||
{ "contactno": "9876543210", "password": "…" }
|
||||
|
||||
// Sign in by username — still works, unchanged
|
||||
{ "authname": "cashier.1135@pos.nearle.in", "password": "xHegDaH55ccWic" }
|
||||
{ "authname": "cashier.1135@pos.nearle.in", "password": "…" }
|
||||
```
|
||||
|
||||
`authname` wins if both are sent. The response is unchanged.
|
||||
@@ -65,7 +65,7 @@ rejection. That did not change.
|
||||
"full_name": "Priya Raman",
|
||||
"role": "cashier",
|
||||
"pin": "4731",
|
||||
"contactno": "9876543210", // NEW — the sign-in number
|
||||
"contactno": "9876543210", // NEW — the sign-in number, and required
|
||||
"shift_id": 3 // NEW — optional, 0/omitted = unassigned
|
||||
}
|
||||
```
|
||||
@@ -164,7 +164,8 @@ locked out on the next app update.
|
||||
|
||||
1. Backend deploys. *(Nothing changes for the app — username login is untouched.)*
|
||||
2. Back office adds a mobile number to every existing till account through the
|
||||
console. New accounts already require one.
|
||||
console. New accounts already require one — `createposuser` refuses a
|
||||
request without it.
|
||||
3. **Only then** the app makes mobile the primary sign-in field.
|
||||
|
||||
**Recommendation for the app:** keep both. One field labelled *"Mobile number or
|
||||
@@ -215,6 +216,6 @@ curl -s -X POST "$B/pos/login" -H 'Content-Type: application/json' \
|
||||
|
||||
# a back-office account is still refused with the specific message
|
||||
curl -s -X POST "$B/pos/login" -H 'Content-Type: application/json' \
|
||||
-d '{"authname":"rmart@gmail.com","password":"rmart@123"}'
|
||||
-d '{"authname":"<a back-office account>","password":"…"}'
|
||||
# expect: 403 "this account is not set up for the till"
|
||||
```
|
||||
|
||||
Reference in New Issue
Block a user