Derive stock and availability from the ledger, not stored fields
Stock shown in the console did not match the productstocks ledger, and two product endpoints were failing outright. Every cause was on the read side or in how the availability flag was maintained; the ledger writes themselves (CreateOrder's "out" entry, cancellation's "in" entry) were already correct. Read fixes, repositories/productRepository.go: - GetProductStocks returned SQLSTATE 42803 on every call: bare a.tenantid / a.stocktype / a.status under GROUP BY a.productid. The per-ledger-row columns are now aggregated and the grouping covers the identity columns. - FetchFilteredProducts filtered on an alias `e` that no query defines, so every /getallproducts call carrying a locationid failed with SQLSTATE 42P01 instead of returning products. - FetchFilteredProducts joined productlocations on productid alone and joined a (productid, locationid)-grouped stock subquery on productid alone, so a product carried by three outlets came back three times, each row showing another outlet's quantity and status. Both are now tenant-scoped subqueries collapsed to one row per product and scoped to the outlet when one is given. - GetProductStocks and FetchFilteredProducts compared stocktype = 'in' case-sensitively. Production holds 'in' and 'IN' both, so uppercase receipts were silently dropped from the balance: one outlet reported 0 for a product holding 50, another reported 0 for twelve products holding 200-840. - GetStockStatement summed opening over stockdate <= CURRENT_DATE, making it arithmetically identical to closing. The Inventory ledger showed the same number in both columns on every row, which reads as stock never moving. Availability flag: productlocations.status was maintained by two different rules — the order path derived it from the balance, the receiving path set 'available' on any "in" entry regardless of the resulting balance. A partial restock that left the balance at or below zero marked a product sellable, and a flag set by an old order never cleared for stock that arrived by a route the API did not own. Both paths now derive the flag from the live balance through one rule: SyncProductLocationStatus (receiving side) and syncProductLocationStatus (order side, inside the caller's transaction). ReactivateProductLocations is replaced by the former; the service no longer filters refs by stocktype, since the direction of the movement is no longer what decides the flag. A row that has already drifted now repairs itself on its next ledger entry. Verified against the live database: all four stock endpoints return matching balances, /getallproducts no longer duplicates rows, and the flag sync was exercised in both directions inside a rolled-back transaction. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -4,7 +4,6 @@ import (
|
||||
"fmt"
|
||||
"nearle/models"
|
||||
"nearle/repositories"
|
||||
"strings"
|
||||
"time"
|
||||
)
|
||||
|
||||
@@ -88,9 +87,12 @@ func (s *productService) CreateProductStock(stocks []models.Productstock) error
|
||||
productIDs = append(productIDs, stk.Productid)
|
||||
}
|
||||
}
|
||||
// Only "in" entries mean stock actually arrived — an "out" entry
|
||||
// (a sale) should never flip a location back to available.
|
||||
if stk.Productid > 0 && stk.Locationid > 0 && stk.Tenantid > 0 && strings.EqualFold(stk.Stocktype, "in") {
|
||||
// Every entry gets synced, "in" and "out" alike: the status is now
|
||||
// derived from the resulting balance rather than assumed from the
|
||||
// direction of the movement, so an "out" that empties a location
|
||||
// flags it outofstock and a partial "in" that leaves the balance at
|
||||
// or below zero correctly does not mark it sellable.
|
||||
if stk.Productid > 0 && stk.Locationid > 0 && stk.Tenantid > 0 {
|
||||
ref := models.ProductLocationRef{Tenantid: stk.Tenantid, Locationid: stk.Locationid, Productid: stk.Productid}
|
||||
if _, exists := locMap[ref]; !exists {
|
||||
locMap[ref] = struct{}{}
|
||||
@@ -106,7 +108,7 @@ func (s *productService) CreateProductStock(stocks []models.Productstock) error
|
||||
}
|
||||
|
||||
if len(locRefs) > 0 {
|
||||
if err := s.repo.ReactivateProductLocations(locRefs); err != nil {
|
||||
if err := s.repo.SyncProductLocationStatus(locRefs); err != nil {
|
||||
return err
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user