Suriyakumarvijayanayagam
02b2c5bc39
Reported from the shipped Windows app. Three faults in one call, and the first is why it failed rather than merely misbehaved. runtime.Show is implemented by Wails as a bare mainWindow.Show(), while runtime.WindowShow wraps the identical work in runtime.LockOSThread. Win32 window operations have to run on the thread owning the window's message pump, and the tray's handler runs on the SYSTRAY's goroutine, which is never that thread. An unlocked Win32 call from an arbitrary goroutine is the bug. Two more that would each have been enough on their own: - Showing is not un-minimising. Hidden and minimised are different states and Show only fixes the first, so a window the user minimised stayed minimised. - Windows refuses the foreground to a process that does not already hold it, so the window came back BEHIND whatever was being looked at. Clicking a tray icon is by definition a moment when this app is not in front, so that is not an edge case here - it is every time. The always-on-top flip is the ordinary way to ask, and it is why this now runs in a goroutine rather than on the menu loop, which must not sleep. The same four calls fix OnSecondInstanceLaunch, which had the same shape and is reached far more often: double-clicking the desktop icon while the app is already running. OnBeforeClose used runtime.Hide against a reopen that used WindowShow - different calls on Windows, one thread-locked and one not. Paired now. And a Mac build, because the question came up and the answer turned out to be yes. Wails' darwin frontend references UTType without linking UniformTypeIdentifiers, so the build failed at the LINK step after compiling everything - which reads like a broken toolchain rather than one missing flag. There was no Mac version because of that, not because of a design limit. darwin_link.go declares the framework in source rather than leaving it as a CGO_LDFLAGS incantation, for the same reason deploy.sh now finds Go itself. Verified: plain `go build` produces a 16 MB arm64 binary on this Mac, and the Windows build is unchanged. Worth knowing for whoever edits that file: the comment directly above `import "C"` is cgo's C preamble, not documentation. The first attempt put the explanation there and the prose was compiled as C. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KGcjxF1cNLcuwc3DAPcnfj
26 lines
1.1 KiB
Go
26 lines
1.1 KiB
Go
//go:build darwin
|
|
|
|
// Link the framework Wails' darwin frontend forgets.
|
|
//
|
|
// It references UTType (UniformTypeIdentifiers) without linking it, so a macOS
|
|
// build fails at the LINK step with `Undefined symbols: _OBJC_CLASS_$_UTType`
|
|
// - after compiling everything successfully, which makes it read like a broken
|
|
// toolchain rather than one missing flag. That is why there was no Mac build:
|
|
// not a design limit, a link error nobody had chased.
|
|
//
|
|
// Declared in the source rather than passed as CGO_LDFLAGS on the command
|
|
// line, for the same reason deploy.sh now finds Go itself: a build that needs
|
|
// the operator to know an incantation is a build that does not happen. Plain
|
|
// `go build` and `wails build` both work on a Mac with this file present, and
|
|
// the build tag makes it inert everywhere else.
|
|
//
|
|
// Note for anyone editing: the comment directly above `import "C"` is cgo's C
|
|
// PREAMBLE, not documentation. This paragraph sits above `package main` on
|
|
// purpose - put it there and the prose is compiled as C, which is how the
|
|
// first attempt failed.
|
|
|
|
package main
|
|
|
|
// #cgo LDFLAGS: -framework UniformTypeIdentifiers
|
|
import "C"
|