release.sh can build the macOS package too
Cheap for a reason worth stating: the Windows package is already a SOURCE install - a pure-Python wheel plus a setup tool that builds a venv on the target machine, because PyInstaller cannot cross-compile. macOS needs nothing different. Same wheel, same setup tool, a natively built .app in place of the .exe. No frozen engine, no 200 MB, no second packaging story. behavision-setup already handled both platforms (Scripts vs bin, the tasklist check guarded) and cross-compiled for darwin without a change. The one thing that did not was its advice when Python is missing: it told everyone to tick 'Add python.exe to PATH' on a Windows installer page. Software that does not know which machine it is running on is software somebody stops trusting for the rest of the session. MAC=1 opts in, so the ordinary Windows release is unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KGcjxF1cNLcuwc3DAPcnfj
This commit is contained in:
@@ -266,10 +266,19 @@ func findPython() (string, string, error) {
|
||||
}
|
||||
}
|
||||
|
||||
msg := "no Python 3.10 or newer was found on this PC.\n\n" +
|
||||
" Install it from https://www.python.org/downloads/windows/\n" +
|
||||
" and tick \"Add python.exe to PATH\" on the first screen,\n" +
|
||||
" then run this again."
|
||||
// The advice has to match the machine. Telling a Mac user to tick "Add
|
||||
// python.exe to PATH" on a Windows installer page reads as software that
|
||||
// does not know where it is running, which is exactly the moment somebody
|
||||
// stops trusting the rest of what it says.
|
||||
msg := "no Python 3.10 or newer was found on this computer.\n\n"
|
||||
if runtime.GOOS == "windows" {
|
||||
msg += " Install it from https://www.python.org/downloads/windows/\n" +
|
||||
" and tick \"Add python.exe to PATH\" on the first screen,\n" +
|
||||
" then run this again."
|
||||
} else {
|
||||
msg += " Install it with `brew install python@3.12`, or from\n" +
|
||||
" https://www.python.org/downloads/macos/, then run this again."
|
||||
}
|
||||
if len(tried) > 0 {
|
||||
msg += "\n\n Found, but too old: " + strings.Join(tried, ", ")
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user