@@ -176,6 +194,40 @@ function CameraSheet({ cam, onClose, onSaved }) {
Three things from the camera: its address, its make, and its password. Test before you save — a wrong address is the most common mistake.
{error &&
{error}
}
+ {isNew && (
+
+ Find it
+ {scan === null && (
+
+
Behavision can look for cameras on this shop’s network.
+
+
Looking on the network… a few seconds.
}
+ {scan?.error && {scan.error}
}
+ {scan?.cameras && (
+ scan.cameras.length === 0
+ ?
+
Nothing answered on {scan.networks?.join(', ') || 'this network'}. The camera may be on a different network, switched off, or not yet connected — check its cable and power, then try again. You can still type its address below.
+
+
+ {scan.cameras.map(c => (
+ -
+
+
+ ))}
+
+
+ )}
+
+ )}
+
The camera
{isNew && (
diff --git a/desktop/internal/local/client.go b/desktop/internal/local/client.go
index ed4030a..b650721 100644
--- a/desktop/internal/local/client.go
+++ b/desktop/internal/local/client.go
@@ -105,6 +105,12 @@ func (c *Client) DeleteCamera(ctx context.Context, id string) error {
return c.do(ctx, http.MethodDelete, "/api/cameras/"+id, nil, nil)
}
+// DiscoverCameras asks the engine to scan the shop's network. A few seconds.
+func (c *Client) DiscoverCameras(ctx context.Context) (map[string]any, error) {
+ var out map[string]any
+ return out, c.do(ctx, http.MethodGet, "/api/cameras/discover", nil, &out)
+}
+
func (c *Client) TestCamera(ctx context.Context, cam map[string]any) (map[string]any, error) {
var out map[string]any
return out, c.do(ctx, http.MethodPost, "/api/cameras/test", cam, &out)
diff --git a/tests/test_discover.py b/tests/test_discover.py
new file mode 100644
index 0000000..8acd218
--- /dev/null
+++ b/tests/test_discover.py
@@ -0,0 +1,44 @@
+"""Discovery parsing, with no network: the two shapes cameras actually send."""
+from behavision.discover import parse_probe_match, guess_make, local_networks
+
+HIK = (''
+ ''
+ 'onvif://www.onvif.org/type/video_encoder onvif://www.onvif.org/name/HIKVISION%20DS-2CD2043G2 '
+ 'onvif://www.onvif.org/hardware/DS-2CD2043G2-I onvif://www.onvif.org/location/city/hangzhou'
+ 'http://192.168.1.122/onvif/device_service'
+ '')
+
+BARE = (''
+ 'http://10.0.0.9:8080/onvif/device_service http://[fe80::1]/onvif'
+ '')
+
+
+def test_hikvision_probe_match_is_named_and_recognised():
+ f = parse_probe_match(HIK, "192.168.1.122")
+ assert f.host == "192.168.1.122"
+ assert f.onvif and not f.rtsp
+ assert "HIKVISION DS-2CD2043G2" in f.name and "DS-2CD2043G2-I" in f.name
+ assert f.make == "hikvision"
+
+
+def test_a_nameless_match_still_yields_its_address():
+ f = parse_probe_match(BARE, "10.0.0.9")
+ assert f.host == "10.0.0.9" and f.name == "" and f.make == ""
+ assert f.onvif_url.startswith("http://10.0.0.9:8080")
+
+
+def test_garbage_is_not_a_camera():
+ assert parse_probe_match("not soap", "1.2.3.4") is None
+
+
+def test_make_guesses_the_common_indian_retail_brands():
+ assert guess_make("CP PLUS CP-UNC-TA21L3") == "cpplus"
+ assert guess_make("Dahua IPC-HDW1230") == "dahua"
+ assert guess_make("TP-LINK Tapo C200") == "tplink"
+ assert guess_make("Something Else") == ""
+
+
+def test_local_networks_are_slash_24_and_never_loopback():
+ for n in local_networks():
+ assert n.prefixlen == 24
+ assert not n.network_address.is_loopback