Aravind
d440036211
Phase 6. 57 files: 23 vendored shadcn primitives, 30 design-system components,
4 charts. Plus `src/components/ds/props.ts`, which is types only.
Renaming these alone took typecheck from 37 to 1008, and the reason is worth
recording because it is the shape of every remaining phase.
These components had NO prop contract. No PropTypes, no validation: in the
JavaScript every prop was optional and every extra prop was spread onto the
underlying element. TypeScript infers a destructured parameter WITHOUT a default
as REQUIRED, so the moment the files became `.tsx` it invented a rule the
components never had and rejected several hundred call sites that have always
worked. That is the compiler describing its own inference, not a defect it
found.
Three mechanical fixes, each restoring a contract that already existed:
- 57 JSDoc `@type {React.ForwardRefExoticComponent<any>}` annotations become
real TypeScript annotations. Those comments were the previous authors'
deliberate compatibility types; JSDoc stops applying in a `.tsx` file, so
converting them preserves an intent that was already written down.
- 61 `React.forwardRef(...)` calls gain `<any, any>`. Without generics `ref`
infers `ForwardedRef<unknown>`, which no element's `Ref<T>` accepts - so
every primitive that forwards a ref to a `div` failed on the ref, not the
props.
- 78 component signatures take `DsProps`, a documented alias for
`Record<string, any>`. It exists so the decision is recorded once and is
greppable when someone tightens it, rather than being 78 bare `any`s with
no explanation between them. The prop NAMES are not lost: every component
still destructures them by name, which is where a reader looks.
Four files needed real types rather than compatibility ones. `ds/toast` takes
react-hot-toast's own `ToastOptions`, which narrows `position` to its
`ToastPosition` union instead of widening to `string` - the widening was what
made all six calls unassignable. `ds/Pagination`'s page range is genuinely
`(number | string)[]`, because it interleaves page numbers with '…' markers that
the renderer tests for. `ds/Field` narrows `children.props` at three reads, and
`ds/Avatar` needed the ref generic.
Two of my own automated passes were wrong and were caught rather than shipped. A
props-interface generator dropped alternating props, because non-overlapping
regex matches consume the separating comma - it made things worse (83 file
errors to 146) and was reverted wholesale. A second pass missed every
multi-line signature whose defaults contain a `)`, such as `onClose = () => {}`;
that needed a brace matcher rather than a character class.
56 of 57 files emit byte-identical JavaScript. The one exception is `ds/toast`,
where a JSDoc type CAST - `/** @type {ToastPosition} */ ('bottom-center')` -
became a real annotation, so the emitted output loses a comment and a pair of
now-redundant parentheses. The value is `"bottom-center"` either way; the
minified outputs differ only in esbuild's choice of mangled local names.
Verified: tsc 37 -> 35, set-difference showing zero introduced and two removed;
zero errors remain in any Phase 6 file; npm test 1684/1691 with the same seven
failures; lint 0 errors; build succeeds with the API origin inlined; baseline
artifacts untouched.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HBG1wnuRfJKCstGB8Fekr8
89 lines
3.0 KiB
TypeScript
89 lines
3.0 KiB
TypeScript
import type { DsProps } from './props';
|
|
import * as React from 'react';
|
|
import { cn } from '@/lib/utils';
|
|
import { Sheet, SheetContent, SheetDescription, SheetHeader, SheetTitle } from '@/components/ui/sheet';
|
|
|
|
/**
|
|
* Panel widths.
|
|
*
|
|
* Each entry states its `max-w` as well as its `w`. The underlying Sheet caps a
|
|
* side panel at `sm:max-w-sm` (24rem), so a width alone was silently ignored on
|
|
* desktop and every "large" drawer in the app was drawn at phone width — the
|
|
* reason detail panels wrapped and scrolled far more than their content needed.
|
|
*/
|
|
const WIDTHS = {
|
|
sm: 'w-full sm:w-80 sm:max-w-[20rem]',
|
|
default: 'w-full sm:w-[28rem] sm:max-w-[28rem]',
|
|
lg: 'w-full sm:w-[36rem] sm:max-w-[36rem]',
|
|
/* A record with a two-column body: 704px on desktop, 768px from `2xl`
|
|
(1536px and up), and never the whole screen — the page behind it stays
|
|
visible, which is what keeps the drawer a drawer. */
|
|
xl: 'w-full sm:w-[44rem] sm:max-w-[44rem] 2xl:w-[48rem] 2xl:max-w-[48rem]',
|
|
};
|
|
|
|
/**
|
|
* Drawer — an edge-anchored panel for detail views, filters and mobile nav.
|
|
*
|
|
* Same header/body/footer contract as Modal, so the two are interchangeable:
|
|
* a detail view can be a Drawer on desktop and a bottom sheet on mobile without
|
|
* its contents changing.
|
|
*/
|
|
/** @param {any} props */
|
|
export function Drawer({
|
|
open,
|
|
onOpenChange,
|
|
title,
|
|
description,
|
|
icon: Icon,
|
|
side = 'right',
|
|
size = 'default',
|
|
footer,
|
|
children,
|
|
className,
|
|
/** Hides the header for a fully custom panel (the mobile nav does this). */
|
|
bare = false,
|
|
}: DsProps) {
|
|
const isVertical = side === 'top' || side === 'bottom';
|
|
|
|
return (
|
|
<Sheet open={open} onOpenChange={onOpenChange}>
|
|
<SheetContent
|
|
side={side}
|
|
className={cn(
|
|
'p-0 gap-0 flex flex-col',
|
|
isVertical ? 'h-auto max-h-[85vh]' : WIDTHS[size],
|
|
className
|
|
)}
|
|
>
|
|
{!bare && (
|
|
<SheetHeader className="px-5 sm:px-6 pt-5 pb-4 border-b border-border shrink-0 space-y-0 text-left">
|
|
<div className="flex items-start gap-3">
|
|
{Icon && (
|
|
<span className="grid place-items-center w-9 h-9 rounded-xl bg-krow-blue-tint text-krow-blue shrink-0">
|
|
<Icon className="w-4.5 h-4.5" aria-hidden="true" />
|
|
</span>
|
|
)}
|
|
<div className="min-w-0">
|
|
<SheetTitle className="text-title font-heading text-ink-1">{title}</SheetTitle>
|
|
{description && (
|
|
<SheetDescription className="text-body-sm text-ink-3 mt-1">
|
|
{description}
|
|
</SheetDescription>
|
|
)}
|
|
</div>
|
|
</div>
|
|
</SheetHeader>
|
|
)}
|
|
|
|
<div className="flex-1 overflow-y-auto px-5 py-5 sm:px-6">{children}</div>
|
|
|
|
{footer && (
|
|
<div className="px-5 sm:px-6 py-4 border-t border-border bg-surface-subtle shrink-0 flex items-center justify-end gap-2">
|
|
{footer}
|
|
</div>
|
|
)}
|
|
</SheetContent>
|
|
</Sheet>
|
|
);
|
|
}
|