chore(ts-migration): migrate components/forge and components/admin to TypeScript

Phase 8, second batch: 16 files. All 16 emit byte-identical JavaScript and the
production bundle is byte-identical to e7e1e98.

`ProfileView` and `CourseView` move from `components/krow/types.ts` to
`@/types/views`, because `components/forge` reads the same `jsonb` columns off
the same courses and profiles. `components/krow/types.ts` stays as a re-export
so that folder's imports are untouched. Two copies of one narrowing would be
two things to keep in step.

SCOPE, decided by imports rather than by folder name. `components/skills` was in
the batch as requested and is DEFERRED: it imports `lib/skills/registry`,
`lib/agents/runtime`, `ai-assistant/PageContext` and `ai-assistant/AgentContext`,
which makes it agent region by the same test this batch used. `ui-tree` and
`ui-editor` are deferred for the same reason - all eleven files drive the UI-node
system, which is Owliver's "move this card" capability. `forge` was checked and
kept: despite the name, it imports nothing from `lib/skills`, `lib/agents` or
`ai-assistant`. It is the worker learning product.

Twenty-six components now declare real props. Two corrections to the pattern
came out of this batch, both from call sites:

  - Optionality. Batch 1 made a prop required when it had no default. That is
    wrong here: `AdminPage` has seventeen call sites and most pass only `title`.
    Required is now reserved for entity-typed props and `children` - what a
    component genuinely cannot render without - and everything else is optional,
    which is what the JavaScript always allowed.

  - Callback arity. `() => void` was too strict: `onOpen`, `onCreate` and
    `onBrowse` are called WITH arguments, and `University` passes a `useState`
    setter straight through, which has one parameter and is therefore not
    assignable to a zero-parameter type. Callbacks take `(...args: any[])`.

`RoleGlyph`'s `GLYPHS` table gets `[RegExp, ComponentType<any>][]` - the same
widening `aiEngine`'s router had, where the element becomes the union of both
positions and neither `pattern.test` nor `<Icon />` works. The author had
already written that exact type as a JSDoc comment; it is now the real
annotation and the comment is gone.

`ForgeHeader` receives `onBrowse` and destructures `_onBrowse`, so the prop is
passed and silently dropped - the same shape as `TalentHero`'s `jobRecs` in the
previous batch. Recorded rather than changed.

Two automated passes were reverted rather than shipped. One added `?` to object
members inside component bodies, not just interface fields, producing
`TS1162: An object member cannot be declared optional` - it was rerun scoped to
`interface XProps` blocks. The other was the generator itself, which annotated
only the FIRST component in each file and so missed `SectionTitle` in
`PageShell`; rewritten to walk every match and splice in reverse, it went from
14 components to 26 and took the error count from 93 to 38.

Two runtime imports were caught by the emitted-JavaScript check and would not
have been caught any other way. The generator added `import * as React` to
`RoleGlyph` for a type-only reference - a real import in the bundle - now
`import type { ComponentType }`. Fixing that, I then removed the React import
`PageShell` genuinely had; restored.

Verified: tsc 22 -> 22, set-difference showing zero introduced and zero removed;
zero errors in any of the 16 files; all 16 emit byte-identical JavaScript;
production bundle byte-identical; npm test 1684/1691 with the same seven
failures; Owliver baseline 59/59; lint 0 errors; baseline artifacts untouched.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HBG1wnuRfJKCstGB8Fekr8

src/components/admin/PageShell.tsx

@@ -17,8 +17,17 @@ import { cn } from '@/lib/utils';
  * Controls live in the page rather than in the global chrome, which is why the
  * Admin header only needs one 56px bar.
  */
-/** @param {any} props */
-export function AdminPage({ title, subtitle, meta, actions, tabs, children, className }) {
+interface AdminPageProps {
+  title?: string;
+  subtitle?: string;
+  meta?: any;
+  actions?: any;
+  tabs?: any;
+  children: React.ReactNode;
+  className?: string;
+}
+
+export function AdminPage({ title, subtitle, meta, actions, tabs, children, className }: AdminPageProps) {
   return (
     <div className={cn('space-y-6', className)}>
       <header className="flex flex-wrap items-center justify-between gap-4 border-b border-border/50 pb-4">
@@ -57,8 +66,15 @@ export function AdminPage({ title, subtitle, meta, actions, tabs, children, clas
  * Sentence-case and small rather than a heavy all-caps overline: on a page with
  * four or five sections, loud labels compete with the data they introduce.
  */
-/** @param {any} props */
-export function SectionTitle({ id, title, meta, action, className }) {
+interface SectionTitleProps {
+  id?: any;
+  title?: string;
+  meta?: any;
+  action?: any;
+  className?: string;
+}
+
+export function SectionTitle({ id, title, meta, action, className }: SectionTitleProps) {
   return (
     <div className={cn('flex flex-wrap items-baseline justify-between gap-2', className)}>
       {/* The count wraps under the section name rather than competing with it
@@ -91,8 +107,15 @@ export function SectionTitle({ id, title, meta, action, className }) {
  * primary action is pushed to the end, so every management page has the same
  * control geometry.
  */
-/** @param {any} props */
-export function Toolbar({ search = null, filters = null, actions = null, meta = null, className = '' }) {
+interface ToolbarProps {
+  search?: any;
+  filters?: any;
+  actions?: any;
+  meta?: any;
+  className?: string;
+}
+
+export function Toolbar({ search = null, filters = null, actions = null, meta = null, className = '' }: ToolbarProps) {
   return (
     <div className={cn('space-y-2', className)}>
       <div className="flex flex-col gap-2 lg:flex-row lg:items-center">

src/components/admin/RoleGlyph.tsx

@@ -1,3 +1,4 @@
+import type { ComponentType } from 'react';
 import {
   Briefcase, ChefHat, ConciergeBell, HardHat, PackageSearch, ShieldCheck, Sparkles, Truck, Wine,
 } from 'lucide-react';
@@ -19,8 +20,10 @@ import { cn } from '@/lib/utils';
  */
 
 /** Category to icon. Matched loosely, so a new "Head Chef" still gets the hat. */
-/** @type {[RegExp, React.ComponentType<any>][]} */
-const GLYPHS = [
+/* `[pattern, icon]` pairs. Without the tuple the element widens to the union of
+   both positions, so `pattern.test` and `<Icon />` both stop working — the same
+   shape as `aiEngine`'s route table. */
+const GLYPHS: [RegExp, ComponentType<any>][] = [
   [/chef|cook|kitchen/i, ChefHat],
   [/bartend|bar|mixolog/i, Wine],
   [/server|wait|host|banquet|concierge/i, ConciergeBell],
@@ -42,8 +45,15 @@ const SIZES = {
   lg: { box: 'h-14 w-14 rounded-xl', icon: 'h-6 w-6' },
 };
 
-/** @param {any} props */
-export function RoleGlyph({ category, title, size = 'md', aiGenerated = false, className = '' }) {
+interface RoleGlyphProps {
+  category?: any;
+  title?: string;
+  size?: any;
+  aiGenerated?: any;
+  className?: string;
+}
+
+export function RoleGlyph({ category, title, size = 'md', aiGenerated = false, className = '' }: RoleGlyphProps) {
   const Icon = iconForRole(category, title);
   const s = SIZES[size] || SIZES.md;