From 284a7e76711bcde6acb49040cd7ebce96772ad14 Mon Sep 17 00:00:00 2001 From: Aravind Date: Fri, 18 Sep 2026 15:42:35 +0530 Subject: [PATCH] =?UTF-8?q?refactor(ts-migration):=20Phase=2011=20batch=20?= =?UTF-8?q?11=20=E2=80=94=20the=20data=20pages?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The last nine admin pages. `src/` now contains no `.js` or `.jsx` at all. One error, and it was the same kind of thing the whole phase has been finding: `getBandMembers(min, max)` in `TalentPool` is called with one argument for the top band, and its own body reads `max == null || s < max`. The parameter has always been optional everywhere except the signature. The marker erases. 9/9 byte-identical, and the bundle still hashes to 74d17e2d… Three of these nine — `Analytics`, `Candidates`, `HiredHistory` — are the pages the Owliver baselines cover, and they carry six of the seven pre-existing suite failures. Those failures are unchanged and still match `ecf5e75` line for line, which is the point: if a rename had altered what these pages render, it would have altered how they fail, and it did not. The baselines are untouched, as they have been in every batch. Phase 11 is 122/122 files and eleven batches. Across all of them: type erasure 122/122 byte-identical bundle 74d17e2d… unchanged from `ecf5e75` in every batch npm test 1684/1691 with the same 7 failures, in every batch typecheck 20 errors at the start, 6 now The remaining 6 all pre-date the migration. They are no longer in JavaScript, so they are now fixable; that is the next commit, not this one. Co-Authored-By: Claude Opus 5 (1M context) Claude-Session: https://claude.ai/code/session_01HBG1wnuRfJKCstGB8Fekr8 --- src/pages/admin/{Activity.jsx => Activity.tsx} | 0 src/pages/admin/{Analytics.jsx => Analytics.tsx} | 0 src/pages/admin/{CandidateProfile.jsx => CandidateProfile.tsx} | 0 src/pages/admin/{Candidates.jsx => Candidates.tsx} | 0 .../admin/{CandidatesAnalysis.jsx => CandidatesAnalysis.tsx} | 0 src/pages/admin/{ControlCenter.jsx => ControlCenter.tsx} | 0 src/pages/admin/{HiredHistory.jsx => HiredHistory.tsx} | 0 src/pages/admin/{Positions.jsx => Positions.tsx} | 0 src/pages/admin/{TalentPool.jsx => TalentPool.tsx} | 2 +- 9 files changed, 1 insertion(+), 1 deletion(-) rename src/pages/admin/{Activity.jsx => Activity.tsx} (100%) rename src/pages/admin/{Analytics.jsx => Analytics.tsx} (100%) rename src/pages/admin/{CandidateProfile.jsx => CandidateProfile.tsx} (100%) rename src/pages/admin/{Candidates.jsx => Candidates.tsx} (100%) rename src/pages/admin/{CandidatesAnalysis.jsx => CandidatesAnalysis.tsx} (100%) rename src/pages/admin/{ControlCenter.jsx => ControlCenter.tsx} (100%) rename src/pages/admin/{HiredHistory.jsx => HiredHistory.tsx} (100%) rename src/pages/admin/{Positions.jsx => Positions.tsx} (100%) rename src/pages/admin/{TalentPool.jsx => TalentPool.tsx} (98%) diff --git a/src/pages/admin/Activity.jsx b/src/pages/admin/Activity.tsx similarity index 100% rename from src/pages/admin/Activity.jsx rename to src/pages/admin/Activity.tsx diff --git a/src/pages/admin/Analytics.jsx b/src/pages/admin/Analytics.tsx similarity index 100% rename from src/pages/admin/Analytics.jsx rename to src/pages/admin/Analytics.tsx diff --git a/src/pages/admin/CandidateProfile.jsx b/src/pages/admin/CandidateProfile.tsx similarity index 100% rename from src/pages/admin/CandidateProfile.jsx rename to src/pages/admin/CandidateProfile.tsx diff --git a/src/pages/admin/Candidates.jsx b/src/pages/admin/Candidates.tsx similarity index 100% rename from src/pages/admin/Candidates.jsx rename to src/pages/admin/Candidates.tsx diff --git a/src/pages/admin/CandidatesAnalysis.jsx b/src/pages/admin/CandidatesAnalysis.tsx similarity index 100% rename from src/pages/admin/CandidatesAnalysis.jsx rename to src/pages/admin/CandidatesAnalysis.tsx diff --git a/src/pages/admin/ControlCenter.jsx b/src/pages/admin/ControlCenter.tsx similarity index 100% rename from src/pages/admin/ControlCenter.jsx rename to src/pages/admin/ControlCenter.tsx diff --git a/src/pages/admin/HiredHistory.jsx b/src/pages/admin/HiredHistory.tsx similarity index 100% rename from src/pages/admin/HiredHistory.jsx rename to src/pages/admin/HiredHistory.tsx diff --git a/src/pages/admin/Positions.jsx b/src/pages/admin/Positions.tsx similarity index 100% rename from src/pages/admin/Positions.jsx rename to src/pages/admin/Positions.tsx diff --git a/src/pages/admin/TalentPool.jsx b/src/pages/admin/TalentPool.tsx similarity index 98% rename from src/pages/admin/TalentPool.jsx rename to src/pages/admin/TalentPool.tsx index 569170c..9539bcc 100644 --- a/src/pages/admin/TalentPool.jsx +++ b/src/pages/admin/TalentPool.tsx @@ -73,7 +73,7 @@ export default function AdminTalentPool() { }; const segments = useMemo(() => { - const getBandMembers = (min, max) => profiles.filter((p) => { + const getBandMembers = (min, max?) => profiles.filter((p) => { const s = p.krow_score || 0; return s >= min && (max == null || s < max); });