krow_backend/go-api/internal/config/model_test.go

package config

import (
	"strings"
	"testing"
)

func modelCfg(env string, m ModelConfig) *Config {
	c := &Config{AppEnv: env}
	c.Model = m
	return c
}

func TestValidateModelProvider(t *testing.T) {
	for _, tc := range []struct {
		name    string
		cfg     *Config
		wantErr bool
	}{
		{
			"unset provider is openai, which is now the only implementation",
			modelCfg("development", ModelConfig{}), false,
		},
		{"openai named explicitly", modelCfg("development", ModelConfig{Provider: "openai"}), false},
		{
			"anthropic is refused rather than ignored — it used to be correct",
			modelCfg("development", ModelConfig{Provider: "anthropic"}), true,
		},
		{"a typo is caught once at startup, not once per run",
			modelCfg("development", ModelConfig{Provider: "openal"}), true},
		{
			"a vendor name is not a provider: groq is reached through openai + a base URL",
			modelCfg("development", ModelConfig{Provider: "groq"}), true,
		},
	} {
		t.Run(tc.name, func(t *testing.T) {
			err := tc.cfg.validateModel()
			if tc.wantErr != (err != nil) {
				t.Fatalf("validateModel() = %v, wantErr = %v", err, tc.wantErr)
			}
		})
	}
}

// THE STALE CONFIGURATION.
//
// This replaced a test called TestBaseURLWithoutOpenAIProviderIsRefused, which
// guarded the mirror image of the same mistake: while both providers existed, a
// base URL without MODEL_PROVIDER=openai meant a deployment that believed it had
// left Claude and had not. That failure is now impossible — there is nowhere
// else for a run to go — and the surviving one points the other way: a
// deployment that still names Anthropic, and must be told rather than silently
// re-pointed at a provider it never chose.
func TestTheRemovedProviderIsRefusedLoudly(t *testing.T) {
	err := modelCfg("development", ModelConfig{Provider: "anthropic"}).validateModel()
	if err == nil {
		t.Fatal("MODEL_PROVIDER=anthropic was accepted; the stack would silently run on another vendor")
	}
	for _, want := range []string{"MODEL_PROVIDER=anthropic", "no longer supported", "MODEL_BASE_URL"} {
		if !strings.Contains(err.Error(), want) {
			t.Errorf("the message does not mention %q:\n  %v", want, err)
		}
	}

	// The intended configuration is exactly what the message tells them to set.
	if err := modelCfg("development", ModelConfig{
		Provider: "openai", BaseURL: "https://api.groq.com/openai/v1",
	}).validateModel(); err != nil {
		t.Fatalf("the intended configuration was refused: %v", err)
	}
}

// A model id that outlived its provider.
//
// The expensive shape of this is not a typo, it is an UNCHANGED .env: the tier
// ids were claude-* for the whole life of the Anthropic path, and nothing about
// switching providers forces them to be revisited. Left unchecked the process
// starts clean and every single run fails at the gateway with a 400 — which is
// the incident that made the gateway start carrying upstream error text at all.
func TestClaudeModelIdsAreRefused(t *testing.T) {
	base := ModelConfig{Provider: "openai", BaseURL: "https://api.groq.com/openai/v1",
		Fast: "llama-3.1-8b-instant", Balanced: "llama-3.3-70b-versatile", Deep: "llama-3.3-70b-versatile"}

	for _, tier := range []string{"MODEL_FAST", "MODEL_BALANCED", "MODEL_DEEP"} {
		t.Run(tier, func(t *testing.T) {
			m := base
			switch tier {
			case "MODEL_FAST":
				m.Fast = "claude-opus-5"
			case "MODEL_BALANCED":
				m.Balanced = "claude-opus-5"
			case "MODEL_DEEP":
				m.Deep = "claude-3-5-sonnet-latest"
			}
			err := modelCfg("development", m).validateModel()
			if err == nil {
				t.Fatalf("%s kept a claude id and was accepted; every run on that tier would 400", tier)
			}
			// Naming the tier is the whole value: "a model is wrong" does not
			// tell an operator which of three lines to edit.
			if !strings.Contains(err.Error(), tier) {
				t.Errorf("the message does not name the tier %q:\n  %v", tier, err)
			}
		})
	}

	if err := modelCfg("development", base).validateModel(); err != nil {
		t.Fatalf("a fully-migrated configuration was refused: %v", err)
	}
}

func TestBaseURLMustBeAURL(t *testing.T) {
	for _, raw := range []string{"api.groq.com", "ftp://x.test", "not a url", "://broken"} {
		err := modelCfg("development", ModelConfig{Provider: "openai", BaseURL: raw}).validateModel()
		if err == nil {
			t.Errorf("MODEL_BASE_URL=%q was accepted", raw)
		}
	}
	for _, raw := range []string{"http://localhost:11434/v1", "https://api.groq.com/openai/v1"} {
		if err := modelCfg("development", ModelConfig{Provider: "openai", BaseURL: raw}).validateModel(); err != nil {
			t.Errorf("MODEL_BASE_URL=%q was refused: %v", raw, err)
		}
	}
}

// Production without a credential fails every run at the gateway, which is a
// misconfiguration wearing a runtime error's clothes. A local model is the one
// exception: it needs no key, and demanding one would make the zero-cost path
// impossible to configure.
func TestProductionCredentialRequirement(t *testing.T) {
	for _, tc := range []struct {
		name    string
		cfg     *Config
		wantErr bool
	}{
		{"production with no key", modelCfg("production", ModelConfig{}), true},
		{"production with a key", modelCfg("production", ModelConfig{APIKey: "k"}), false},
		{
			"production against a local model needs no key",
			modelCfg("production", ModelConfig{Provider: "openai", BaseURL: "http://localhost:11434/v1"}),
			false,
		},
		{
			"production against a hosted provider still does",
			modelCfg("production", ModelConfig{Provider: "openai", BaseURL: "https://api.groq.com/openai/v1"}),
			true,
		},
		{"development needs nothing", modelCfg("development", ModelConfig{}), false},
	} {
		t.Run(tc.name, func(t *testing.T) {
			err := tc.cfg.validateModel()
			if tc.wantErr != (err != nil) {
				t.Fatalf("validateModel() = %v, wantErr = %v", err, tc.wantErr)
			}
		})
	}
}

func TestIsLoopback(t *testing.T) {
	for raw, want := range map[string]bool{
		"http://localhost:11434/v1": true,
		"http://127.0.0.1:11434/v1": true,
		"https://api.groq.com/v1":   false,
		"":                          false,
		// A remote host that merely mentions localhost in its path is not local.
		"https://x.test/localhost/v1": false,
	} {
		if got := isLoopback(raw); got != want {
			t.Errorf("isLoopback(%q) = %v, want %v", raw, got, want)
		}
	}
}