Add CORS credentials, transactional endpoints, and container deployment #1
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Krow/krow_backend#1
Reference in New Issue
Block a user
Delete Branch "feat/cors-transactions-docker"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
CORS
cors.go never set Access-Control-Allow-Credentials, so the
cookie-authenticated API was unreadable from any cross-origin frontend:
the server answered correctly and the browser blocked the page from
reading it. Set for allowlisted origins on both the preflight and the
actual response. Three tests added.
HTTP_COOKIE_SAMESITE (lax|none|strict, default lax) is new. CORS is only
half of what a cross-origin browser call needs; SameSite is judged on
registrable domain, so a frontend on an unrelated domain gets perfect CORS
headers and still no cookie. "none" is the only value that survives that,
and validate() refuses it without the Secure flag.
The "" rejection now explains itself: browsers refuse Allow-Origin ""
together with credentials, so it would break every authenticated call
rather than loosen anything.
Transactional endpoints (api-contract.md 12.1)
POST /api/v1/job-applications/{id}/hire
POST /api/v1/job-postings/{id}/assignments
Replaces two client-side loops that wrote several records with no
transaction and no rollback. Each is now one endpoint and one transaction,
built over repo.Repo so org scoping, derived columns, type casts and error
translation are not re-derived. Authorization reuses the existing policy
table rather than adding a parallel one: a workflow is exactly as
privileged as the writes it performs. 13 tests, including both rollback
paths.
Bug fix in the repository layer
repo.bindValue handled int64/int/float64/string but not int32, which is
what pgx returns for a PostgreSQL
intcolumn. Nothing previously read arecord and wrote one of its fields elsewhere, so it never surfaced; the
hire flow does exactly that and failed with "ai_score must be a number".
Both KindInt and KindFloat now accept the widths pgx actually produces.
Deployment
infrastructure/Dockerfile.api multi-stage, cross-compiling (BUILDPLATFORM
+ GOARCH) so linux/amd64 builds from arm64 are compiled rather than
emulated. Alpine runtime, non-root uid 10001, 22.1 MB. Ships api, seed,
setpassword and migrate, plus the migrations, so a Kubernetes
initContainer can apply the schema from the same image and tag as the
API. HEALTHCHECK keys on status code, not body, so a "degraded" instance
is not pulled from rotation during a migration window.
infrastructure/docker-compose.yml migrations run to completion before the
API starts. Assumes a managed PostgreSQL; the local-db overlay adds one
with TLS enabled so APP_ENV=production is met rather than dodged.
scripts/drop_public_tables.go the one-off used to clear an unrelated
schema from krowdb on 2026-08-24, kept for the record. Build-tagged
ignore and gated on CONFIRM_DROP=yes.
Verified against PostgreSQL: 16/16 new tests pass, and the image was built,
run and exercised end to end (login, CORS preflight, authenticated reads,
transaction rollback).
Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01CmQiGq73Uyfq7J4yR8Vxxw
CORS cors.go never set Access-Control-Allow-Credentials, so the cookie-authenticated API was unreadable from any cross-origin frontend: the server answered correctly and the browser blocked the page from reading it. Set for allowlisted origins on both the preflight and the actual response. Three tests added. HTTP_COOKIE_SAMESITE (lax|none|strict, default lax) is new. CORS is only half of what a cross-origin browser call needs; SameSite is judged on registrable domain, so a frontend on an unrelated domain gets perfect CORS headers and still no cookie. "none" is the only value that survives that, and validate() refuses it without the Secure flag. The "*" rejection now explains itself: browsers refuse Allow-Origin "*" together with credentials, so it would break every authenticated call rather than loosen anything. Transactional endpoints (api-contract.md 12.1) POST /api/v1/job-applications/{id}/hire POST /api/v1/job-postings/{id}/assignments Replaces two client-side loops that wrote several records with no transaction and no rollback. Each is now one endpoint and one transaction, built over repo.Repo so org scoping, derived columns, type casts and error translation are not re-derived. Authorization reuses the existing policy table rather than adding a parallel one: a workflow is exactly as privileged as the writes it performs. 13 tests, including both rollback paths. Bug fix in the repository layer repo.bindValue handled int64/int/float64/string but not int32, which is what pgx returns for a PostgreSQL `int` column. Nothing previously read a record and wrote one of its fields elsewhere, so it never surfaced; the hire flow does exactly that and failed with "ai_score must be a number". Both KindInt and KindFloat now accept the widths pgx actually produces. Deployment infrastructure/Dockerfile.api multi-stage, cross-compiling (BUILDPLATFORM + GOARCH) so linux/amd64 builds from arm64 are compiled rather than emulated. Alpine runtime, non-root uid 10001, 22.1 MB. Ships api, seed, setpassword and migrate, plus the migrations, so a Kubernetes initContainer can apply the schema from the same image and tag as the API. HEALTHCHECK keys on status code, not body, so a "degraded" instance is not pulled from rotation during a migration window. infrastructure/docker-compose.yml migrations run to completion before the API starts. Assumes a managed PostgreSQL; the local-db overlay adds one with TLS enabled so APP_ENV=production is met rather than dodged. scripts/drop_public_tables.go the one-off used to clear an unrelated schema from krowdb on 2026-08-24, kept for the record. Build-tagged ignore and gated on CONFIRM_DROP=yes. Verified against PostgreSQL: 16/16 new tests pass, and the image was built, run and exercised end to end (login, CORS preflight, authenticated reads, transaction rollback). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CmQiGq73Uyfq7J4yR8Vxxw