Krow/Krow-workspace
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
a3aab678fd53bcb692c6f2dfb843dd30e4c56c2a
Krow-workspace/.claude/agent-memory/architecture-reviewer/MEMORY.md
Achintha Isuru 316a148726 feat: Implement review order flow for one-time, recurring, and permanent orders 
- Added ReviewOrderPage to handle order review before submission.
- Created ReviewOrderArguments model to pass data between pages.
- Implemented schedule sections for one-time, recurring, and permanent orders.
- Enhanced navigation flow to confirm order submission after review.
- Refactored order submission logic in OneTimeOrderPage, PermanentOrderPage, and RecurringOrderPage.
- Introduced utility functions for time parsing and scheduling.
- Created reusable widgets for displaying order information in the review section.
- Updated navigation methods to use popSafe for safer back navigation.
- Added MainActivity for Android platform integration.
2026-03-09 19:49:23 -04:00

1.7 KiB
Raw Blame History

Architecture Reviewer Memory

Project Structure Confirmed

  • Feature packages: apps/mobile/packages/features/<app>/<feature>/
  • Domain: apps/mobile/packages/domain/
  • Design system: apps/mobile/packages/design_system/
  • Core: apps/mobile/packages/core/
  • Data Connect: apps/mobile/packages/data_connect/
  • client_orders_common is at apps/mobile/packages/features/client/orders/orders_common/ (shared across order features)

BLoC Registration Pattern

  • BLoCs registered with i.add<>() (transient) per CLAUDE.md -- NOT singletons
  • This means BlocProvider(create:) is CORRECT (not BlocProvider.value())
  • SafeBloc mixin exists in core alongside BlocErrorHandler

Known Pre-existing Issues (create_order feature)

  • All 3 order BLoCs make direct _service.connector calls for loading vendors, hubs, roles, and managers instead of going through use cases/repositories (CRITICAL per rules, but pre-existing)
  • firebase_data_connect and firebase_auth are listed as direct dependencies in client_create_order/pubspec.yaml (should only be in data_connect package)
  • All 3 order pages use Modular.to.pop() instead of Modular.to.popSafe() for the back button

Design System Tokens

  • Colors: UiColors.*
  • Typography: UiTypography.*
  • Spacing: UiConstants.space* (e.g., space3, space4, space6)
  • App bar: UiAppBar

Review Patterns (grep-based checks)

  • Color(0x for hardcoded colors
  • TextStyle( for custom text styles
  • Navigator. for direct navigator usage
  • import.*features/ for cross-feature imports (must be zero)
  • _service.connector in BLoC files for direct data connect calls
  • Modular.to.pop() for unsafe navigation (should be popSafe())
Reference in New Issue View Git Blame Copy Permalink