From e73698e64f5a6a50d718bccbd5b6f75f095e3b05 Mon Sep 17 00:00:00 2001 From: Achintha Isuru Date: Wed, 28 Jan 2026 10:12:05 -0500 Subject: [PATCH] fix: update LocaleBloc and LocaleRepositoryImpl to use named parameters for better clarity --- .../core_localization/lib/src/bloc/locale_bloc.dart | 2 +- .../data/repositories_impl/locale_repository_impl.dart | 10 +++++----- .../core_localization/lib/src/localization_module.dart | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/apps/mobile/packages/core_localization/lib/src/bloc/locale_bloc.dart b/apps/mobile/packages/core_localization/lib/src/bloc/locale_bloc.dart index 27b3c4ce..48d7683f 100644 --- a/apps/mobile/packages/core_localization/lib/src/bloc/locale_bloc.dart +++ b/apps/mobile/packages/core_localization/lib/src/bloc/locale_bloc.dart @@ -55,7 +55,7 @@ class LocaleBloc extends Bloc { final Locale? savedLocale = await getLocaleUseCase(); final Locale locale = savedLocale ?? const Locale('es'); - LocaleSettings.setLocaleRaw(locale.languageCode); + await LocaleSettings.setLocaleRaw(locale.languageCode); emit(LocaleState(locale: locale, supportedLocales: state.supportedLocales)); } diff --git a/apps/mobile/packages/core_localization/lib/src/data/repositories_impl/locale_repository_impl.dart b/apps/mobile/packages/core_localization/lib/src/data/repositories_impl/locale_repository_impl.dart index ddda18cb..2711edb2 100644 --- a/apps/mobile/packages/core_localization/lib/src/data/repositories_impl/locale_repository_impl.dart +++ b/apps/mobile/packages/core_localization/lib/src/data/repositories_impl/locale_repository_impl.dart @@ -7,19 +7,19 @@ import '../datasources/locale_local_data_source.dart'; /// This class handles the mapping between domain [Locale] objects and the raw /// strings handled by the [LocaleLocalDataSource]. class LocaleRepositoryImpl implements LocaleRepositoryInterface { - final LocaleLocalDataSource _localDataSource; + /// Creates a [LocaleRepositoryImpl] with the provided [localDataSource]. + LocaleRepositoryImpl({required this.localDataSource}); - /// Creates a [LocaleRepositoryImpl] with the provided [_localDataSource]. - LocaleRepositoryImpl(this._localDataSource); + final LocaleLocalDataSource localDataSource; @override Future saveLocale(Locale locale) { - return _localDataSource.saveLanguageCode(locale.languageCode); + return localDataSource.saveLanguageCode(locale.languageCode); } @override Future getSavedLocale() async { - final String? languageCode = await _localDataSource.getLanguageCode(); + final String? languageCode = await localDataSource.getLanguageCode(); if (languageCode != null) { return Locale(languageCode); } diff --git a/apps/mobile/packages/core_localization/lib/src/localization_module.dart b/apps/mobile/packages/core_localization/lib/src/localization_module.dart index e292120f..13177b1c 100644 --- a/apps/mobile/packages/core_localization/lib/src/localization_module.dart +++ b/apps/mobile/packages/core_localization/lib/src/localization_module.dart @@ -24,7 +24,7 @@ class LocalizationModule extends Module { // Repositories i.addLazySingleton( - () => LocaleRepositoryImpl(i.get()), + () => LocaleRepositoryImpl(localDataSource: i.get()), ); // Use Cases