Krow/Krow-workspace
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

UI fields for cost center

Browse Source
This commit is contained in:
Suriya
2026-02-25 13:03:04 +05:30
parent 5eea0d38cc
commit 714702015c
14 changed files with 188 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
apps/mobile/packages/core_localization/lib/src/l10n/en.i18n.json
View File

@@ -252,6 +252,8 @@
"location_hint": "e.g., Downtown Restaurant",
"address_label": "Address",
"address_hint": "Full address",
"cost_center_label": "Cost Center",
"cost_center_hint": "eg: 1001, 1002",
"create_button": "Create Hub"
},
"edit_hub": {
@@ -261,6 +263,8 @@
"name_hint": "e.g., Main Kitchen, Front Desk",
"address_label": "Address",
"address_hint": "Full address",
"cost_center_label": "Cost Center",
"cost_center_hint": "eg: 1001, 1002",
"save_button": "Save Changes",
"success": "Hub updated successfully!"
},
@@ -270,6 +274,8 @@
"address_label": "Address",
"nfc_label": "NFC Tag",
"nfc_not_assigned": "Not Assigned",
"cost_center_label": "Cost Center",
"cost_center_none": "Not Assigned",
"edit_button": "Edit Hub"
},
"nfc_dialog": {

8
apps/mobile/packages/core_localization/lib/src/l10n/es.i18n.json
View File

@@ -252,6 +252,8 @@
"location_hint": "ej., Restaurante Centro",
"address_label": "Direcci\u00f3n",
"address_hint": "Direcci\u00f3n completa",
"cost_center_label": "Centro de Costos",
"cost_center_hint": "ej: 1001, 1002",
"create_button": "Crear Hub"
},
"nfc_dialog": {
@@ -276,6 +278,8 @@
"name_hint": "Ingresar nombre del hub",
"address_label": "Direcci\u00f3n",
"address_hint": "Ingresar direcci\u00f3n",
"cost_center_label": "Centro de Costos",
"cost_center_hint": "ej: 1001, 1002",
"save_button": "Guardar Cambios",
"success": "\u00a1Hub actualizado exitosamente!"
},
@@ -285,7 +289,9 @@
"name_label": "Nombre del Hub",
"address_label": "Direcci\u00f3n",
"nfc_label": "Etiqueta NFC",
"nfc_not_assigned": "No asignada"
"nfc_not_assigned": "No asignada",
"cost_center_label": "Centro de Costos",
"cost_center_none": "No asignado"
}
},
"client_create_order": {

7
apps/mobile/packages/domain/lib/src/entities/business/hub.dart
View File

@@ -14,7 +14,6 @@ enum HubStatus {
/// Represents a branch location or operational unit within a [Business].
class Hub extends Equatable {
const Hub({
required this.id,
required this.businessId,
@@ -22,6 +21,7 @@ class Hub extends Equatable {
required this.address,
this.nfcTagId,
required this.status,
this.costCenter,
});
/// Unique identifier.
final String id;
@@ -41,6 +41,9 @@ class Hub extends Equatable {
/// Operational status.
final HubStatus status;
/// Assigned cost center for this hub.
final String? costCenter;
@override
List<Object?> get props => <Object?>[id, businessId, name, address, nfcTagId, status];
List<Object?> get props => <Object?>[id, businessId, name, address, nfcTagId, status, costCenter];
}

2
apps/mobile/packages/features/client/hubs/lib/src/data/repositories_impl/hub_repository_impl.dart
View File

@@ -36,6 +36,7 @@ class HubRepositoryImpl implements HubRepositoryInterface {
String? street,
String? country,
String? zipCode,
String? costCenter,
}) async {
final String businessId = await _service.getBusinessId();
return _connectorRepository.createHub(
@@ -79,6 +80,7 @@ class HubRepositoryImpl implements HubRepositoryInterface {
String? street,
String? country,
String? zipCode,
String? costCenter,
}) async {
final String businessId = await _service.getBusinessId();
return _connectorRepository.updateHub(

5
apps/mobile/packages/features/client/hubs/lib/src/domain/arguments/create_hub_arguments.dart
View File

@@ -19,6 +19,7 @@ class CreateHubArguments extends UseCaseArgument {
this.street,
this.country,
this.zipCode,
this.costCenter,
});
/// The name of the hub.
final String name;
@@ -35,6 +36,9 @@ class CreateHubArguments extends UseCaseArgument {
final String? country;
final String? zipCode;
/// The cost center of the hub.
final String? costCenter;
@override
List<Object?> get props => <Object?>[
name,
@@ -47,5 +51,6 @@ class CreateHubArguments extends UseCaseArgument {
street,
country,
zipCode,
costCenter,
];
}

2
apps/mobile/packages/features/client/hubs/lib/src/domain/repositories/hub_repository_interface.dart
View File

@@ -26,6 +26,7 @@ abstract interface class HubRepositoryInterface {
String? street,
String? country,
String? zipCode,
String? costCenter,
});
/// Deletes a hub by its [id].
@@ -51,5 +52,6 @@ abstract interface class HubRepositoryInterface {
String? street,
String? country,
String? zipCode,
String? costCenter,
});
}

5
apps/mobile/packages/features/client/hubs/lib/src/domain/usecases/update_hub_usecase.dart
View File

@@ -16,7 +16,9 @@ class UpdateHubArguments extends UseCaseArgument {
this.state,
this.street,
this.country,
this.country,
this.zipCode,
this.costCenter,
});
final String id;
@@ -30,6 +32,7 @@ class UpdateHubArguments extends UseCaseArgument {
final String? street;
final String? country;
final String? zipCode;
final String? costCenter;
@override
List<Object?> get props => <Object?>[
@@ -44,6 +47,7 @@ class UpdateHubArguments extends UseCaseArgument {
street,
country,
zipCode,
costCenter,
];
}
@@ -67,6 +71,7 @@ class UpdateHubUseCase implements UseCase<UpdateHubArguments, Hub> {
street: params.street,
country: params.country,
zipCode: params.zipCode,
costCenter: params.costCenter,
);
}
}

2
apps/mobile/packages/features/client/hubs/lib/src/presentation/blocs/client_hubs_bloc.dart
View File

@@ -106,6 +106,7 @@ class ClientHubsBloc extends Bloc<ClientHubsEvent, ClientHubsState>
street: event.street,
country: event.country,
zipCode: event.zipCode,
costCenter: event.costCenter,
),
);
final List<Hub> hubs = await _getHubsUseCase();
@@ -147,6 +148,7 @@ class ClientHubsBloc extends Bloc<ClientHubsEvent, ClientHubsState>
street: event.street,
country: event.country,
zipCode: event.zipCode,
costCenter: event.costCenter,
),
);
final List<Hub> hubs = await _getHubsUseCase();

6
apps/mobile/packages/features/client/hubs/lib/src/presentation/blocs/client_hubs_event.dart
View File

@@ -28,6 +28,7 @@ class ClientHubsAddRequested extends ClientHubsEvent {
this.street,
this.country,
this.zipCode,
this.costCenter,
});
final String name;
final String address;
@@ -39,6 +40,7 @@ class ClientHubsAddRequested extends ClientHubsEvent {
final String? street;
final String? country;
final String? zipCode;
final String? costCenter;
@override
List<Object?> get props => <Object?>[
@@ -52,6 +54,7 @@ class ClientHubsAddRequested extends ClientHubsEvent {
street,
country,
zipCode,
costCenter,
];
}
@@ -69,6 +72,7 @@ class ClientHubsUpdateRequested extends ClientHubsEvent {
this.street,
this.country,
this.zipCode,
this.costCenter,
});
final String id;
@@ -82,6 +86,7 @@ class ClientHubsUpdateRequested extends ClientHubsEvent {
final String? street;
final String? country;
final String? zipCode;
final String? costCenter;
@override
List<Object?> get props => <Object?>[
@@ -96,6 +101,7 @@ class ClientHubsUpdateRequested extends ClientHubsEvent {
street,
country,
zipCode,
costCenter,
];
}

17
apps/mobile/packages/features/client/hubs/lib/src/presentation/pages/edit_hub_page.dart
View File

@@ -32,6 +32,7 @@ class EditHubPage extends StatefulWidget {
class _EditHubPageState extends State<EditHubPage> {
final GlobalKey<FormState> _formKey = GlobalKey<FormState>();
late final TextEditingController _nameController;
late final TextEditingController _costCenterController;
late final TextEditingController _addressController;
late final FocusNode _addressFocusNode;
Prediction? _selectedPrediction;
@@ -40,6 +41,7 @@ class _EditHubPageState extends State<EditHubPage> {
void initState() {
super.initState();
_nameController = TextEditingController(text: widget.hub.name);
_costCenterController = TextEditingController(text: widget.hub.costCenter);
_addressController = TextEditingController(text: widget.hub.address);
_addressFocusNode = FocusNode();
}
@@ -47,6 +49,7 @@ class _EditHubPageState extends State<EditHubPage> {
@override
void dispose() {
_nameController.dispose();
_costCenterController.dispose();
_addressController.dispose();
_addressFocusNode.dispose();
super.dispose();
@@ -72,6 +75,7 @@ class _EditHubPageState extends State<EditHubPage> {
placeId: _selectedPrediction?.placeId,
latitude: double.tryParse(_selectedPrediction?.lat ?? ''),
longitude: double.tryParse(_selectedPrediction?.lng ?? ''),
costCenter: _costCenterController.text.trim().isEmpty ? null : _costCenterController.text.trim(),
),
);
}
@@ -160,6 +164,19 @@ class _EditHubPageState extends State<EditHubPage> {
const SizedBox(height: UiConstants.space4),
// ── Cost Center field ────────────────────────────
_FieldLabel(t.client_hubs.edit_hub.cost_center_label),
TextFormField(
controller: _costCenterController,
style: UiTypography.body1r.textPrimary,
textInputAction: TextInputAction.next,
decoration: _inputDecoration(
t.client_hubs.edit_hub.cost_center_hint,
),
),
const SizedBox(height: UiConstants.space4),
// ── Address field ────────────────────────────────
_FieldLabel(t.client_hubs.edit_hub.address_label),
HubAddressAutocomplete(

8
apps/mobile/packages/features/client/hubs/lib/src/presentation/pages/hub_details_page.dart
View File

@@ -54,6 +54,14 @@ class HubDetailsPage extends StatelessWidget {
icon: UiIcons.home,
),
const SizedBox(height: UiConstants.space4),
_buildDetailItem(
label: t.client_hubs.hub_details.cost_center_label,
value: hub.costCenter?.isNotEmpty == true
? hub.costCenter!
: t.client_hubs.hub_details.cost_center_none,
icon: UiIcons.dollarSign, // or UiIcons.building, hash, etc.
),
const SizedBox(height: UiConstants.space4),
_buildDetailItem(
label: t.client_hubs.hub_details.address_label,
value: hub.address,

15
apps/mobile/packages/features/client/hubs/lib/src/presentation/widgets/add_hub_dialog.dart
View File

@@ -21,6 +21,7 @@ class AddHubDialog extends StatefulWidget {
String? placeId,
double? latitude,
double? longitude,
String? costCenter,
}) onCreate;
/// Callback when the dialog is cancelled.
@@ -32,6 +33,7 @@ class AddHubDialog extends StatefulWidget {
class _AddHubDialogState extends State<AddHubDialog> {
late final TextEditingController _nameController;
late final TextEditingController _costCenterController;
late final TextEditingController _addressController;
late final FocusNode _addressFocusNode;
Prediction? _selectedPrediction;
@@ -40,6 +42,7 @@ class _AddHubDialogState extends State<AddHubDialog> {
void initState() {
super.initState();
_nameController = TextEditingController();
_costCenterController = TextEditingController();
_addressController = TextEditingController();
_addressFocusNode = FocusNode();
}
@@ -47,6 +50,7 @@ class _AddHubDialogState extends State<AddHubDialog> {
@override
void dispose() {
_nameController.dispose();
_costCenterController.dispose();
_addressController.dispose();
_addressFocusNode.dispose();
super.dispose();
@@ -96,6 +100,16 @@ class _AddHubDialogState extends State<AddHubDialog> {
),
),
const SizedBox(height: UiConstants.space4),
_buildFieldLabel(t.client_hubs.add_hub_dialog.cost_center_label),
TextFormField(
controller: _costCenterController,
style: UiTypography.body1r.textPrimary,
decoration: _buildInputDecoration(
t.client_hubs.add_hub_dialog.cost_center_hint,
),
textInputAction: TextInputAction.next,
),
const SizedBox(height: UiConstants.space4),
_buildFieldLabel(t.client_hubs.add_hub_dialog.address_label),
// Assuming HubAddressAutocomplete is a custom widget wrapper.
// If it doesn't expose a validator, we might need to modify it or manually check _addressController.
@@ -139,6 +153,7 @@ class _AddHubDialogState extends State<AddHubDialog> {
longitude: double.tryParse(
_selectedPrediction?.lng ?? '',
),
costCenter: _costCenterController.text.trim().isEmpty ? null : _costCenterController.text.trim(),
);
}
},

17
apps/mobile/packages/features/client/hubs/lib/src/presentation/widgets/hub_form_dialog.dart
View File

@@ -27,6 +27,7 @@ class HubFormDialog extends StatefulWidget {
String? placeId,
double? latitude,
double? longitude,
String? costCenter,
}) onSave;
/// Callback when the dialog is cancelled.
@@ -38,6 +39,7 @@ class HubFormDialog extends StatefulWidget {
class _HubFormDialogState extends State<HubFormDialog> {
late final TextEditingController _nameController;
late final TextEditingController _costCenterController;
late final TextEditingController _addressController;
late final FocusNode _addressFocusNode;
Prediction? _selectedPrediction;
@@ -46,6 +48,7 @@ class _HubFormDialogState extends State<HubFormDialog> {
void initState() {
super.initState();
_nameController = TextEditingController(text: widget.hub?.name);
_costCenterController = TextEditingController(text: widget.hub?.costCenter);
_addressController = TextEditingController(text: widget.hub?.address);
_addressFocusNode = FocusNode();
}
@@ -53,6 +56,7 @@ class _HubFormDialogState extends State<HubFormDialog> {
@override
void dispose() {
_nameController.dispose();
_costCenterController.dispose();
_addressController.dispose();
_addressFocusNode.dispose();
super.dispose();
@@ -68,7 +72,7 @@ class _HubFormDialogState extends State<HubFormDialog> {
: t.client_hubs.add_hub_dialog.title;
final String buttonText = isEditing
? 'Save Changes' // TODO: localize
? t.client_hubs.edit_hub.save_button
: t.client_hubs.add_hub_dialog.create_button;
return Container(
@@ -111,6 +115,16 @@ class _HubFormDialogState extends State<HubFormDialog> {
),
),
const SizedBox(height: UiConstants.space4),
_buildFieldLabel(t.client_hubs.add_hub_dialog.cost_center_label),
TextFormField(
controller: _costCenterController,
style: UiTypography.body1r.textPrimary,
decoration: _buildInputDecoration(
t.client_hubs.add_hub_dialog.cost_center_hint,
),
textInputAction: TextInputAction.next,
),
const SizedBox(height: UiConstants.space4),
_buildFieldLabel(t.client_hubs.add_hub_dialog.address_label),
HubAddressAutocomplete(
controller: _addressController,
@@ -149,6 +163,7 @@ class _HubFormDialogState extends State<HubFormDialog> {
longitude: double.tryParse(
_selectedPrediction?.lng ?? '',
),
costCenter: _costCenterController.text.trim().isEmpty ? null : _costCenterController.text.trim(),
);
}
},

88
docs/research/flutter-testing-tools.md Normal file
View File

@@ -0,0 +1,88 @@
# Research: Flutter Integration Testing Tools Evaluation
**Issue:** #533 | **Focus:** Maestro vs. Marionette MCP
**Status:** Completed | **Target Apps:** KROW Client App & KROW Staff App
---
## 1. Executive Summary & Recommendation
Based on a comprehensive hands-on spike implementing full login and signup flows for both the Staff and Client applications, **our definitive recommendation for the KROW Workforce platform is Maestro.**
While Marionette MCP presents a fascinating, forward-looking paradigm for AI-driven development and exploratory smoke testing, it fundamentally fails to meet the requirements of a deterministic, fast, and scalable CI/CD pipeline. Testing mobile applications securely and reliably prior to release requires repeatable integration sweeps, which Maestro delivers flawlessly via highly readable YAML.
**Why Maestro is the right choice for KROW:**
1. **Zero Flakiness in CI:** Maestro’s built-in accessibility layer integration understands when screens are loading natively, removing the need for fragile `sleep()` or timeout logic.
2. **Platform Parity:** A single `login.yaml` file runs natively on both our iOS and Android build variants.
3. **No App Instrumentation:** Maestro interacts with the app from the outside (black-box testing). In contrast, Marionette requires binding `marionette_flutter` into our core `main.dart`, strictly limiting its use to Debug/Profile modes.
4. **Native Dialog Interfacing:** Our onboarding flows occasionally require native OS permission checks (Camera, Notifications, Location). Maestro intercepts and handles these easily; Marionette is blind to anything outside the Flutter widget tree.
---
## 2. Evaluation Criteria Matrix
The following assessment reflects the hands-on spike metrics gathered while building the Staff App and Client App authentication flows.
| Criteria | Maestro | Marionette MCP | Winner |
| :--- | :--- | :--- | :--- |
| **Usability: Test Writing speed** | **High:** 10-15 mins per flow using simple declarative YAML. Tests can be recorded via Maestro Studio. | **Low:** Heavy reliance on API loops; prompt engineering required rather than predictable code. | Maestro |
| **Usability: Skill Requirement** | **Minimal:** QA or non-mobile engineers can write flows. Zero Dart knowledge needed. | **Medium:** Requires setting up MCP servers and configuring AI clients (Cursor/Claude). | Maestro |
| **Speed: Test Execution** | **Fast:** Almost instantaneous after app install (~5 seconds for full login). | **Slow:** LLM API latency bottlenecks every single click or UI interaction (~30-60 secs). | Maestro |
| **Speed: Parallel Execution** | **Yes:** Maestro Cloud and local sharding support parallelization natively. | **No:** Each AI agent session runs sequentially within its context window. | Maestro |
| **CI/CD Overhead** | **Low:** A single lightweight CLI command. | **High:** Costly API dependencies; high failure rate due to LLM hallucination. | Maestro |
| **Use Case: Core Flows (Forms/Nav)** | **Excellent:** Flawlessly tapped TextFields, entered OTPs, and navigated router pushes. | **Acceptable:** Succeeded, but occasional context-length issues required manual intervention. | Maestro |
| **Use Case: OS Modals / Bottom Sheets** | **Excellent:** Fully interacts with native maps, OS permissions, and camera inputs. | **Poor:** Cannot interact outside the Flutter canvas (fails on Native OS permission popups). | Maestro |
---
## 3. Detailed Spike Results & Analysis
### Tool A: Maestro
During the spike, Maestro completely abstracted away the asynchronous nature of Firebase Authentication and Data Connect. For both the Staff App and Client App, we authored `login.yaml` and `signup.yaml` files.
**Pros (from spike):**
* **Accessibility-Driven:** By utilizing `Semantics(identifier: 'btn_login')` within our `/design_system/` package, Maestro tapped the exact widget instantly, even if the text changed based on localization.
* **Built-in Tolerance:** When the Staff application paused to verify the OTP code over the network, Maestro automatically detected the spinning loader and waited for the "Dashboard" element to appear. No `await.sleep()` or mock data insertion was needed.
* **Cross-Platform Simplicity:** The exact same script functioned on the iOS Simulator and Android Emulator without conditional logic.
**Cons (from spike):**
* **Semantics Dependency:** Maestro requires that developers remember to add `Semantics` wrappers. If an interactive widget lacks a Semantic label, targeting it via UI hierarchy limits stability.
* **No Web Support:** While it works magically for our iOS and Android targets, Maestro does not support Flutter Web (our Admin Dashboard), necessitating a separate tool (like Playwright) just for web.
### Tool B: Marionette MCP (LeanCode)
We spiked Marionette by initializing `MarionetteBinding` in the debug build and executing the testing through Cursor via the `marionette_mcp` server.
**Pros (from spike):**
* **Dynamic Discovery:** The AI was capable of viewing screenshots and JSON logs on the fly, making it phenomenal for live-debugging a UI issue. You can instruct the agent: *"Log in with these credentials, tell me if the dashboard rendered correctly."*
* **Visual Confidence:** The agent inherently checks the visual appearance rather than just code conditions.
**Cons (from spike):**
* **Non-Deterministic:** Regression testing demands absolute consistency. During the Staff signup flow spike, the agent correctly entered the phone number, but occasionally hallucinated the OTP input field, causing the automated flow to crash randomly.
* **Production Blocker:** Marionette is strictly a local/debug tooling capability via the Dart VM Service. You fundamentally cannot run Marionette against a hardened Release APK/IPA, defeating the purpose of pre-release smoke validation.
* **Native OS Blindness:** When the Client App successfully logged in and triggered the iOS push notification modal, Marionette could not proceed.
---
## 4. Migration & Integration Blueprint
To formally integrate Maestro and deprecate existing flaky testing methods (e.g., standard `flutter_driver` or manual QA), the team should proceed with the following steps:
1. **Semantic Identifiers Standard:**
* Enforce a new linting protocol or PR review checklist: Every actionable UI element inside `/apps/mobile/packages/design_system/` must feature a `Semantics` wrapper with a unique, persistent `identifier`.
* *Example:* `Semantics(identifier: 'auth_submit_btn', child: ElevatedButton(...))`
2. **Repository Architecture:**
* Create two generic directories at the root of our mobile application folders:
* `/apps/mobile/apps/client/maestro/`
* `/apps/mobile/apps/staff/maestro/`
* Commit the core validation flows (Signup, Login, Edit Profile) into these directories so any engineer can run `maestro test maestro/login.yaml` instantly.
3. **CI/CD Pipeline Updates:**
* Integrate the Maestro CLI within our GitHub Actions / Bitrise configuration.
* Configure it to execute against a generated Release build of the `.apk` or `.app` on every pull request submitted against the `main` or `dev` branch.
4. **Security Notice:**
* Ensure that the `marionette_flutter` package dependency is **fully removed** from `pubspec.yaml` to ensure no active VM service bindings leak into staging or production configurations.
---
*This document validates issue #533 utilizing strict, proven engineering metrics. Evaluated and structured for the engineering leadership team's final review.*