refactor: centralize data connect error handling and resolve build issues across applications
This commit addresses several critical issues across the mobile monorepo:
1. Centralized Error Handling: Integrated DataErrorHandler mixin into all repository implementations, ensuring consistent mapping of Data Connect exceptions to domain AppExceptions.
2. Build Stabilization: Fixed numerous type mismatches, parameter signature errors in widgets (e.g., google_places_flutter itemBuilder), and naming conflicts (StaffSession, FirebaseAuth).
3. Code Quality: Applied 'dart fix' across all modified packages and manually cleared debug print statements and UI clutter.
4. Mono-repo alignment: Standardized Data Connect usage and aliasing ('dc.') for better maintainability.
Signed-off-by: Suriya <suriya@tenext.in>
This commit is contained in:
@@ -16,13 +16,11 @@ import 'presentation/pages/billing_page.dart';
|
||||
class BillingModule extends Module {
|
||||
@override
|
||||
void binds(Injector i) {
|
||||
// Mock repositories (TODO: Replace with real implementations)
|
||||
i.addSingleton<FinancialRepositoryMock>(FinancialRepositoryMock.new);
|
||||
|
||||
|
||||
// Repositories
|
||||
i.addSingleton<BillingRepository>(
|
||||
() => BillingRepositoryImpl(
|
||||
financialRepository: i.get<FinancialRepositoryMock>(),
|
||||
dataConnect: ExampleConnector.instance,
|
||||
),
|
||||
);
|
||||
|
||||
@@ -12,28 +12,34 @@ import '../../domain/repositories/billing_repository.dart';
|
||||
/// It strictly adheres to the Clean Architecture data layer responsibilities:
|
||||
/// - No business logic (except necessary data transformation/filtering).
|
||||
/// - Delegates to data sources.
|
||||
class BillingRepositoryImpl implements BillingRepository {
|
||||
class BillingRepositoryImpl
|
||||
with data_connect.DataErrorHandler
|
||||
implements BillingRepository {
|
||||
/// Creates a [BillingRepositoryImpl].
|
||||
///
|
||||
/// Requires the [financialRepository] to fetch financial data.
|
||||
BillingRepositoryImpl({
|
||||
required data_connect.FinancialRepositoryMock financialRepository,
|
||||
required data_connect.ExampleConnector dataConnect,
|
||||
}) : _financialRepository = financialRepository,
|
||||
_dataConnect = dataConnect;
|
||||
}) : _dataConnect = dataConnect;
|
||||
|
||||
final data_connect.FinancialRepositoryMock _financialRepository;
|
||||
final data_connect.ExampleConnector _dataConnect;
|
||||
|
||||
/// Fetches the current bill amount by aggregating open invoices.
|
||||
@override
|
||||
@override
|
||||
Future<double> getCurrentBillAmount() async {
|
||||
// In a real app, this might be an aggregate query.
|
||||
// Simulating fetching invoices and summing up.
|
||||
final List<Invoice> invoices = await _financialRepository.getInvoices(
|
||||
'current_business',
|
||||
);
|
||||
return invoices
|
||||
final String? businessId =
|
||||
data_connect.ClientSessionStore.instance.session?.business?.id;
|
||||
if (businessId == null || businessId.isEmpty) {
|
||||
return 0.0;
|
||||
}
|
||||
|
||||
final fdc.QueryResult<data_connect.ListInvoicesByBusinessIdData, data_connect.ListInvoicesByBusinessIdVariables> result = await executeProtected(() => _dataConnect
|
||||
.listInvoicesByBusinessId(businessId: businessId)
|
||||
.execute());
|
||||
|
||||
return result.data.invoices
|
||||
.map(_mapInvoice)
|
||||
.where((Invoice i) => i.status == InvoiceStatus.open)
|
||||
.fold<double>(
|
||||
0.0,
|
||||
@@ -50,25 +56,32 @@ class BillingRepositoryImpl implements BillingRepository {
|
||||
return <Invoice>[];
|
||||
}
|
||||
|
||||
final fdc.QueryResult<data_connect.ListInvoicesByBusinessIdData,
|
||||
data_connect.ListInvoicesByBusinessIdVariables> result =
|
||||
await _dataConnect
|
||||
final fdc.QueryResult<data_connect.ListInvoicesByBusinessIdData, data_connect.ListInvoicesByBusinessIdVariables> result = await executeProtected(() => _dataConnect
|
||||
.listInvoicesByBusinessId(
|
||||
businessId: businessId,
|
||||
)
|
||||
.limit(10)
|
||||
.execute();
|
||||
.execute());
|
||||
|
||||
return result.data.invoices.map(_mapInvoice).toList();
|
||||
}
|
||||
|
||||
/// Fetches pending invoices (Open or Disputed).
|
||||
@override
|
||||
@override
|
||||
Future<List<Invoice>> getPendingInvoices() async {
|
||||
final List<Invoice> invoices = await _financialRepository.getInvoices(
|
||||
'current_business',
|
||||
);
|
||||
return invoices
|
||||
final String? businessId =
|
||||
data_connect.ClientSessionStore.instance.session?.business?.id;
|
||||
if (businessId == null || businessId.isEmpty) {
|
||||
return <Invoice>[];
|
||||
}
|
||||
|
||||
final fdc.QueryResult<data_connect.ListInvoicesByBusinessIdData, data_connect.ListInvoicesByBusinessIdVariables> result = await executeProtected(() => _dataConnect
|
||||
.listInvoicesByBusinessId(businessId: businessId)
|
||||
.execute());
|
||||
|
||||
return result.data.invoices
|
||||
.map(_mapInvoice)
|
||||
.where(
|
||||
(Invoice i) =>
|
||||
i.status == InvoiceStatus.open ||
|
||||
@@ -111,16 +124,13 @@ class BillingRepositoryImpl implements BillingRepository {
|
||||
end = DateTime(now.year, now.month + 1, 0, 23, 59, 59, 999);
|
||||
}
|
||||
|
||||
final fdc.QueryResult<
|
||||
data_connect.ListShiftRolesByBusinessAndDatesSummaryData,
|
||||
data_connect.ListShiftRolesByBusinessAndDatesSummaryVariables> result =
|
||||
await _dataConnect
|
||||
final fdc.QueryResult<data_connect.ListShiftRolesByBusinessAndDatesSummaryData, data_connect.ListShiftRolesByBusinessAndDatesSummaryVariables> result = await executeProtected(() => _dataConnect
|
||||
.listShiftRolesByBusinessAndDatesSummary(
|
||||
businessId: businessId,
|
||||
start: _toTimestamp(start),
|
||||
end: _toTimestamp(end),
|
||||
)
|
||||
.execute();
|
||||
.execute());
|
||||
|
||||
final List<data_connect.ListShiftRolesByBusinessAndDatesSummaryShiftRoles>
|
||||
shiftRoles = result.data.shiftRoles;
|
||||
|
||||
@@ -1,6 +1,5 @@
|
||||
import 'package:flutter_bloc/flutter_bloc.dart';
|
||||
import 'package:krow_domain/krow_domain.dart';
|
||||
import '../../domain/models/billing_period.dart';
|
||||
import '../../domain/usecases/get_current_bill_amount.dart';
|
||||
import '../../domain/usecases/get_invoice_history.dart';
|
||||
import '../../domain/usecases/get_pending_invoices.dart';
|
||||
|
||||
Reference in New Issue
Block a user