diff --git a/src/lib/ZoneContext.jsx b/src/lib/ZoneContext.jsx index 106f989..d632ffa 100644 --- a/src/lib/ZoneContext.jsx +++ b/src/lib/ZoneContext.jsx @@ -23,15 +23,11 @@ export function ZoneProvider({ children }) { const tenantId = user?.tenantid || localStorage.getItem('tenantid') || ''; const isTenantUser = Boolean(tenantId && tenantId !== '0'); - // A client login's city (from the login response), used to offer them the - // Doormile hubs of their own city. Missing on a session signed in before the - // backend sent it, in which case every active hub is offered. - const clientCityId = user?.applocationid != null && String(user.applocationid) !== '0' ? String(user.applocationid) : ''; - - // Staff see Doormile's hubs. A client sees their own locations (kitchens, - // depots) AND the Doormile hubs of their city: a newly onboarded client had - // no locations at all, so their zone list was just "All Zones" and the - // Coimbatore hub their orders run through never appeared. + // Staff see Doormile's hubs. A client sees ONLY its own locations (kitchens, + // depots). Doormile's hubs used to be appended for the client's city, and + // for every city whenever the session carried no city (any login made + // before the backend sent one), which is how a Coimbatore client ended up + // offered Hyderabad and Bangalore hubs. const { data: rawHubs = [], isLoading: isHubsLoading, refetch: refetchHubs } = useHubs(); const { data: tenantLocations = [], isLoading: isLocationsLoading, refetch: refetchLocations } = useTenantLocations( isTenantUser ? tenantId : null, @@ -72,14 +68,11 @@ export function ZoneProvider({ children }) { isTenantLocation: true, status: 'Active', })); - const cityHubs = clientCityId - ? doormileHubs.filter((hub) => String(hub.applocationid ?? '') === clientCityId) - : doormileHubs; - return [...own, ...cityHubs]; + return own; } return doormileHubs; - }, [isTenantUser, tenantLocations, rawHubs, clientCityId]); + }, [isTenantUser, tenantLocations, rawHubs]); const zones = useMemo(() => { return [ALL_ZONE, ...activeHubs]; diff --git a/tests/lib/ZoneContext.test.jsx b/tests/lib/ZoneContext.test.jsx index d7d4974..66ba783 100644 --- a/tests/lib/ZoneContext.test.jsx +++ b/tests/lib/ZoneContext.test.jsx @@ -79,34 +79,35 @@ describe('ZoneContext', () => { longitude: 77.6408 }; - // A client sees their own locations first, then the Doormile hubs. A newly - // onboarded client used to have no locations and therefore no zones at all - // — not even the Coimbatore hub their orders run through. - it('should offer the tenant own locations and then the Doormile hubs', () => { + // A client sees only its own locations, never Doormile's hubs. + it('should offer the tenant only its own locations', () => { const { result } = setup({ user: { tenantid: '4' }, locations: [LOCATION] }); expect(result.current.isTenantUser).toBe(true); - expect(result.current.zones.map((z) => z.hubname)).toEqual(['All Zones', 'Indiranagar Kitchen', 'Koramangala Hub']); + expect(result.current.zones.map((z) => z.hubname)).toEqual(['All Zones', 'Indiranagar Kitchen']); expect(result.current.zones[1].hubtype).toBe('kitchen_hub'); expect(result.current.zones[1].isTenantLocation).toBe(true); - expect(result.current.zones[2].isTenantLocation).toBeFalsy(); }); it('should prefix a location zone id so it cannot collide with a hub id', () => { const { result } = setup({ user: { tenantid: '4' }, locations: [{ ...LOCATION, tenantlocationid: 2 }] }); - expect(result.current.zones.map((z) => z.hubid)).toEqual(['all', 'loc:2', '2']); + expect(result.current.zones.map((z) => z.hubid)).toEqual(['all', 'loc:2']); expect(result.current.zones[1].locationid).toBe('2'); }); - it('should offer only the hubs of the client own city when the login carries it', () => { + // The Sai's Kitchen report: a Coimbatore client was offered Hyderabad and + // Bangalore hubs, because a session without a city fell back to every hub. + it('should never offer Doormile hubs to a client, with or without a city', () => { const CBE = { ...KORAMANGALA, hubid: '7', hubname: 'Coimbatore Neptune Hub', applocationid: 1 }; - const BLR = { ...KORAMANGALA, applocationid: 3 }; - const { result } = setup({ user: { tenantid: '4', applocationid: 1 }, hubs: [CBE, BLR] }); - expect(result.current.zones.map((z) => z.hubname)).toEqual(['All Zones', 'Coimbatore Neptune Hub']); + const HYD = { ...KORAMANGALA, hubid: '8', hubname: 'Hyderabad Mars Hub', applocationid: 2 }; + for (const user of [{ tenantid: '4', applocationid: 1 }, { tenantid: '4' }]) { + const { result } = setup({ user, hubs: [CBE, HYD, KORAMANGALA], locations: [LOCATION] }); + expect(result.current.zones.map((z) => z.hubname)).toEqual(['All Zones', 'Indiranagar Kitchen']); + } }); - it('should still show the hubs to a client with no locations yet', () => { + it('should show a client with no locations yet only All Zones', () => { const { result } = setup({ user: { tenantid: '4' }, locations: [] }); - expect(result.current.zones.map((z) => z.hubname)).toEqual(['All Zones', 'Koramangala Hub']); + expect(result.current.zones.map((z) => z.hubname)).toEqual(['All Zones']); }); it('should scope the location query to the operator own tenant', () => { diff --git a/tests/lib/zoneHubIds.test.jsx b/tests/lib/zoneHubIds.test.jsx index d988996..86503d2 100644 --- a/tests/lib/zoneHubIds.test.jsx +++ b/tests/lib/zoneHubIds.test.jsx @@ -104,16 +104,11 @@ describe('a tenant session never matches on a hub id', () => { })).toBe(true); }); - it('a client who picks a Doormile HUB is matched on hub ids, never on location ids', () => { + it('a client cannot pick a Doormile hub: a stale hub id falls back to All Zones', () => { const { result } = setup({ user: { tenantid: '13' }, locations: [KITCHEN] }); - expect(inZone(result, '5', { - bookingid: 5, bookingno: 'DM-H', tenantid: '13', pickuphubid: 5, - pickupaddress: 'Gate 3', deliveryaddress: 'Block C' - })).toBe(true); - expect(inZone(result, '5', { - bookingid: 6, bookingno: 'DM-L', tenantid: '13', tenantlocationid: 5, - pickupaddress: 'Gate 3', deliveryaddress: 'Block C' - })).toBe(false); + expect(result.current.zones.map((z) => z.hubid)).not.toContain('5'); + act(() => result.current.setSelectedZoneId('5')); + expect(result.current.isAllZones).toBe(true); }); it("never shows a client another tenant's order, whatever zone is picked", () => {