Session expiry, arrival geofence guard, multi-destination stops
Three fixes found by running the app on a real handset against production. 1. An expired token left the app looking signed in and unable to work. MilerApi.onUnauthorized was declared and called on every 401 but never assigned, so the token was dropped and nothing else happened: the profile stayed on disk, logged_out stayed false, and the rider saw his own name over a dashboard whose every call returned 401. He reads that as "no work today". The teardown now lives in endSession() and both ways out of a session — the Log out button and the 401 path — use it. 2. Arrived was written locally even when the rider was not there. updateArrivedStatus answers false for three different things and the caller treated all of them as "the write did not land", which is only true of one. A geofence refusal and a server refusal now stop the rung and hand back the reason; a dead network still advances, as it should. 3. A multi-destination customer pickup collapsed onto one stop. GET /miler/bookings returns a row per destination once collected, all with the same bookingid and reference. Every local store keys on that id, so the accepted store deduped two of three drops away and their consignment ids were unrecoverable. orderid is now the stop key; bookingreference stays the booking's name. Cards show "Stop 2 of 3" and the receiver's own name and number rather than the sender's. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EqVJPB9B4QuieZnBAAKgYQ
This commit is contained in:
@@ -69,7 +69,7 @@ void main() {
|
||||
expect(tester.getSize(find.byType(OfflineBanner)).height, lessThan(64));
|
||||
});
|
||||
|
||||
testWidgets('it says what happens next, not just what is wrong', (
|
||||
testWidgets('it says what happens next, and promises nothing it cannot do', (
|
||||
tester,
|
||||
) async {
|
||||
await pump(tester, offline: true);
|
||||
@@ -83,7 +83,28 @@ void main() {
|
||||
.first
|
||||
.data!;
|
||||
expect(text, contains('Offline'));
|
||||
expect(text.toLowerCase(), contains('sync'));
|
||||
|
||||
// ── This used to assert the opposite ──
|
||||
//
|
||||
// It required the word "sync", and the banner duly said "Changes will sync
|
||||
// when you're back online". **There is no mutation queue in this app** — no
|
||||
// outbox, no replay, no retry loop. A status the rider set with no signal
|
||||
// was attempted once, failed, and was never sent again. The banner was
|
||||
// promising a mechanism that does not exist, to the one person who would be
|
||||
// blamed when the hub had no record of the stop.
|
||||
//
|
||||
// If a queue is ever built, this assertion is the place to reverse — and
|
||||
// the copy may promise a sync again on the day something performs one.
|
||||
expect(
|
||||
text.toLowerCase(),
|
||||
isNot(contains('sync')),
|
||||
reason: 'nothing in this app replays a failed mutation',
|
||||
);
|
||||
expect(
|
||||
text.toLowerCase(),
|
||||
contains('connection'),
|
||||
reason: 'it must still say what he needs, not only that he is offline',
|
||||
);
|
||||
});
|
||||
|
||||
testWidgets('online, it occupies no space at all', (tester) async {
|
||||
|
||||
Reference in New Issue
Block a user