Session expiry, arrival geofence guard, multi-destination stops
Three fixes found by running the app on a real handset against production. 1. An expired token left the app looking signed in and unable to work. MilerApi.onUnauthorized was declared and called on every 401 but never assigned, so the token was dropped and nothing else happened: the profile stayed on disk, logged_out stayed false, and the rider saw his own name over a dashboard whose every call returned 401. He reads that as "no work today". The teardown now lives in endSession() and both ways out of a session — the Log out button and the 401 path — use it. 2. Arrived was written locally even when the rider was not there. updateArrivedStatus answers false for three different things and the caller treated all of them as "the write did not land", which is only true of one. A geofence refusal and a server refusal now stop the rung and hand back the reason; a dead network still advances, as it should. 3. A multi-destination customer pickup collapsed onto one stop. GET /miler/bookings returns a row per destination once collected, all with the same bookingid and reference. Every local store keys on that id, so the accepted store deduped two of three drops away and their consignment ids were unrecoverable. orderid is now the stop key; bookingreference stays the booking's name. Cards show "Stop 2 of 3" and the receiver's own name and number rather than the sender's. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EqVJPB9B4QuieZnBAAKgYQ
This commit is contained in:
@@ -207,10 +207,22 @@ void main() {
|
||||
);
|
||||
});
|
||||
|
||||
test('the other line’s records are not this one’s', () async {
|
||||
test('but the other line’s records ARE this one’s', () async {
|
||||
// Reversed 2026-09-16 with the removal of the line from [WorkScope].
|
||||
// Under one-Miler this rule lost a rider his own work: a meal drop and a
|
||||
// parcel collection finished in the same shift are both his, and filing
|
||||
// them in two drawers meant Activity showed him half his day and no
|
||||
// explanation for the other half.
|
||||
//
|
||||
// Ownership is still enforced — see the test above, which is the one that
|
||||
// was actually protecting anything.
|
||||
await addCompletedBookings([done('a')], terminalStatus: 'delivered');
|
||||
ServiceProfile.setActive(ServiceProfile.parcel);
|
||||
expect(await getCompletedOrderIds(), isEmpty);
|
||||
expect(
|
||||
await getCompletedOrderIds(),
|
||||
contains('a'),
|
||||
reason: 'one rider, one day, one history',
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
|
||||
Reference in New Issue
Block a user