docs: record build/vet verification and commit c272a33 in CLAUDE.md
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
37
CLAUDE.md
37
CLAUDE.md
@@ -281,11 +281,14 @@ websocket routes. **[verified this session]**
|
||||
`hubController.go` (**added this session**) — restricts a bookings query
|
||||
to the requesting hub staff's own tenant if partner-scoped, no-ops for
|
||||
Doormile staff. Use on any new hub-console bookings query.
|
||||
- **No Go toolchain was available in the prior sandbox session.** Every
|
||||
change was verified by hand (field/column names cross-checked against
|
||||
real structs, brace-balance via `grep -o "{" | wc -l` vs `}`) but **never
|
||||
actually compiled**. Run `go build ./...` before trusting any of it — the
|
||||
single most important unfinished step from that session.
|
||||
- **Go toolchain was unavailable in the sandbox that wrote this session's
|
||||
changes.** Every change was verified by hand (field/column names
|
||||
cross-checked against real structs, brace-balance via `grep -o "{" |
|
||||
wc -l` vs `}`) at write time. **[verified separately, on Suriya's own
|
||||
machine]**: `go build ./...` and `go vet ./...` were both run afterward
|
||||
and passed clean (only pulled two missing indirect modules,
|
||||
`tinylib/msgp` and `philhofer/fwd`). This was the first actual compiler
|
||||
verification of this code — commit `c272a33`, pushed to `origin/main`.
|
||||
|
||||
---
|
||||
|
||||
@@ -379,14 +382,18 @@ Suriya's own call, looked low-traffic in the old system.
|
||||
### 8.3 Verified vs not, for this migration slice
|
||||
**Verified**: every new handler's field/column names checked by hand
|
||||
against real structs; brace-balance confirmed after every edit; no
|
||||
duplicate symbol definitions.
|
||||
duplicate symbol definitions. **`go build ./...` and `go vet ./...` both
|
||||
pass clean** (verified on Suriya's machine, not the sandbox that wrote the
|
||||
code) — committed as `c272a33`, pushed to `origin/main`. The hand-verified
|
||||
code compiled correctly the first time it hit a real toolchain.
|
||||
**Not verified**:
|
||||
1. `go build ./...` — never run, no Go toolchain in that sandbox.
|
||||
2. No integration test has hit any of the 14 new endpoints.
|
||||
3. The `Tenantid` migration hasn't executed against a real DB yet — will
|
||||
1. No integration test has hit any of the 14 new endpoints — a clean
|
||||
compile says the code is well-formed, not that it behaves correctly
|
||||
against a real DB/Redis/NATS.
|
||||
2. The `Tenantid` migration hasn't executed against a real DB yet — will
|
||||
run automatically via `AutoMigrate` next deploy (additive, nullable,
|
||||
safe).
|
||||
4. **Nothing on the client side has changed.** The rider Flutter app and
|
||||
3. **Nothing on the client side has changed.** The rider Flutter app and
|
||||
`doormile_express_console` still call `jupiter.nearle.app`. API coverage
|
||||
existing on Doormile does not mean traffic is using it. Not a
|
||||
flip-a-URL cutover either — response shapes are completely different
|
||||
@@ -407,9 +414,9 @@ duplicate symbol definitions.
|
||||
finished.
|
||||
- Go-live preparation across the 4 target cities is still ahead.
|
||||
|
||||
**Migration-slice-specific (§8.3)**: `go build` verification, integration
|
||||
testing of the 14 new endpoints, running the `Tenantid` migration, and the
|
||||
client-app rewrites are all still pending.
|
||||
**Migration-slice-specific (§8.3)**: `go build` verification is now done
|
||||
(commit `c272a33`). Still pending: integration testing of the 14 new
|
||||
endpoints, running the `Tenantid` migration, and the client-app rewrites.
|
||||
|
||||
---
|
||||
|
||||
@@ -439,8 +446,8 @@ client-app rewrites are all still pending.
|
||||
|
||||
1. Resolve the customer-JWT E2E test blocker (real phone or load-test
|
||||
workaround) and finish the load test.
|
||||
2. `go build ./...` in `DoormileBackend`, fix anything that doesn't
|
||||
compile — nothing from the migration session has ever been compiled.
|
||||
2. ~~`go build ./...` in `DoormileBackend`~~ — **done**, clean pass,
|
||||
commit `c272a33` pushed to `origin/main`.
|
||||
3. Stand up a test/staging DB, let `AutoMigrate` run, smoke-test the 14 new
|
||||
migration-session endpoints with real requests.
|
||||
4. Pick one low-risk console slice (e.g. Reports or Partner management —
|
||||
|
||||
Reference in New Issue
Block a user