Doormile/doormile_backend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "updates on the otp updates on the customer app"

Browse Source 
This reverts commit 89321c9e06.
This commit is contained in:
dharaneesh-r
2026-09-15 11:58:53 +05:30
parent 89321c9e06
commit 5c73d769ca
17 changed files with 68 additions and 1071 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
db/connect.go
View File

@@ -5,7 +5,6 @@ import (
"database/sql"
"fmt"
"os"
"strings"
"time"
"doormile/config"
@@ -143,17 +142,6 @@ func InitRedis(cfg *config.Config) {
}
func InitNATS(cfg *config.Config) {
// No URL means NATS is deliberately not configured, so do not connect.
// This used to default to the production cluster, which meant any local
// run joined the live stream and competed with the real workers for the
// same durable pull consumer — messages got redelivered rather than lost,
// but it was production churn caused by someone running the repo.
if strings.TrimSpace(cfg.NatsURL) == "" {
utils.Info("NATS_URL is not set — running without NATS. " +
"Publishes are dropped and no consumer is started.")
return
}
var err error
Nc, err = nats.Connect(
cfg.NatsURL,

50
db/nats_guard_test.go
View File

@@ -1,50 +0,0 @@
package db
import (
"testing"
"doormile/config"
)
// DM-06: NATS_URL used to default to the production cluster, so a backend run
// locally with no NATS configuration silently joined the live stream and
// competed with the production workers for the same durable pull consumer.
// That happened for real on 2026-09-11.
//
// The default is now empty, and empty must mean "do not connect" rather than
// "connect to whatever nats.Connect does with an empty string" — which would
// be localhost:4222, i.e. still a connection attempt.
func TestInitNATSSkipsWhenNoURLIsConfigured(t *testing.T) {
previousNc, previousJs := Nc, Js
t.Cleanup(func() { Nc, Js = previousNc, previousJs })
Nc, Js = nil, nil
for _, url := range []string{"", " "} {
Nc, Js = nil, nil
InitNATS(&config.Config{NatsURL: url})
if Nc != nil {
t.Errorf("NatsURL=%q opened a connection; empty must mean no NATS", url)
Nc.Close()
Nc = nil
}
if Js != nil {
t.Errorf("NatsURL=%q initialised JetStream; empty must mean no NATS", url)
}
}
}
// The config side of the same guarantee: no NATS setting may carry a real
// default, or the guard above is bypassed before it is ever reached.
func TestNATSConfigHasNoProductionDefaults(t *testing.T) {
for _, key := range []string{"NATS_URL", "NATS_USER", "NATS_PASSWORD"} {
t.Setenv(key, "")
}
t.Setenv("JWT_SECRET_KEY", "test")
t.Setenv("ENV", "development")
cfg := config.Load()
if cfg.NatsURL != "" || cfg.NatsUser != "" || cfg.NatsPassword != "" {
t.Errorf("NATS settings defaulted to %q / %q / %q — all must be empty",
cfg.NatsURL, cfg.NatsUser, cfg.NatsPassword)
}
}